Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests should test against distribution builds #987

Closed
starpit opened this issue May 29, 2018 · 0 comments
Closed

tests should test against distribution builds #987

starpit opened this issue May 29, 2018 · 0 comments
Labels
tests

Comments

@starpit
Copy link
Member

starpit commented May 29, 2018

right now, the electron builder part of the repo is not tested; the tests run against an electron . mode, i.e. pointing to the local files.

we should instead do a dist build, and run the tests against that built binary
@starpit starpit added the tests label May 29, 2018
starpit added a commit that referenced this issue May 29, 2018
@starpit
run travis tests against a distribution build
53bad34 
Fixes #987
@starpit starpit mentioned this issue May 29, 2018
Closed
starpit added a commit to starpit/shell that referenced this issue May 29, 2018
@starpit
update travis tests to test against distribution build
fbe1e76 
Fixes ibm-functions#987
starpit added a commit to starpit/shell that referenced this issue May 29, 2018
@starpit
update travis tests to test against distribution build
94c026d 
Fixes ibm-functions#987
@starpit starpit mentioned this issue May 29, 2018
Merged
starpit added a commit to starpit/shell that referenced this issue May 29, 2018
@starpit
update travis tests to test against distribution build
94090f6 
Fixes ibm-functions#987
starpit added a commit to starpit/shell that referenced this issue May 30, 2018
@starpit
update travis tests to test against distribution build
829d93c 
Fixes ibm-functions#987
starpit added a commit to starpit/shell that referenced this issue May 30, 2018
@starpit
update travis tests to test against distribution build
a50f59b 
Fixes ibm-functions#987
starpit added a commit to starpit/shell that referenced this issue May 30, 2018
@starpit
update travis tests to test against distribution build
f9c5ca3 
Fixes ibm-functions#987
starpit added a commit to starpit/shell that referenced this issue May 30, 2018
@starpit
update travis tests to test against distribution build
d3c6ce2 
Fixes ibm-functions#987
starpit added a commit to starpit/shell that referenced this issue May 30, 2018
@starpit
update travis tests to test against distribution build
4d31576 
Fixes ibm-functions#987
starpit added a commit to starpit/shell that referenced this issue May 30, 2018
@starpit
update travis tests to test against distribution build
8706d3b 
Fixes ibm-functions#987
starpit added a commit to starpit/shell that referenced this issue May 30, 2018
@starpit
update travis tests to test against distribution build
c676532 
Fixes ibm-functions#987
starpit added a commit to starpit/shell that referenced this issue May 30, 2018
@starpit
update travis tests to test against distribution build
a2e1cd1 
Fixes ibm-functions#987
starpit added a commit to starpit/shell that referenced this issue May 30, 2018
@starpit
update travis tests to test against distribution build
672b8d6 
Fixes ibm-functions#987
starpit added a commit to starpit/shell that referenced this issue May 30, 2018
@starpit
update travis tests to test against distribution build
3ab7e58 
Fixes ibm-functions#987
starpit added a commit to starpit/shell that referenced this issue May 30, 2018
@starpit
update travis tests to test against distribution build
736b2fb 
Fixes ibm-functions#987
starpit added a commit to starpit/shell that referenced this issue May 30, 2018
@starpit
update travis tests to test against distribution build
d8dda85 
Fixes ibm-functions#987
starpit added a commit that referenced this issue May 30, 2018
@starpit
update travis tests to test against distribution build
65c4683 
Fixes #987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Milestone
No milestone
Development

No branches or pull requests
1 participant
@starpit