Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipl: fix reading 4k disk's geometry #107

Closed

Commits on Feb 10, 2021

  1. zipl: fix reading 4k disk's geometry

    Fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1918723
    
    On 4k SCSI disks zipl stores wrong values to 'scsi_mbr.program_table_pointer',
    which makes system unbootable.
    This happens in 'zipl/src/disk.c:656':
    
    ```
    /* Convert file system block to physical */
    *physical = mapped * phy_per_fs + subblock;
    /* Add partition start */
    *physical += info->geo.start;
    
    ```
    
    So 'hd_geometry.start' should be adjusted before being used.
    
    Signed-off-by: Nikita Dubrovskii <nikita@linux.ibm.com>
    nikita-dubrovskii committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    0b1f11d View commit details
    Browse the repository at this point in the history