Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd/cpi.service: Add RemainAfterExit=yes #72

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Contributor

Noticed this while looking at the unit file for a different
RHEL CoreOS issue.

See ostreedev/ostree#1697
and https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=750683

Omitting this can cause the service to run multiple times if
something else ends up depending on it, which I'm guessing
we don't want.

Signed-off-by: Colin Walters walters@verbum.org

Noticed this while looking at the unit file for a different
RHEL CoreOS issue.

See ostreedev/ostree#1697
and https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=750683

Omitting this can cause the service to run multiple times if
something else ends up depending on it, which I'm guessing
we don't want.

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters
Copy link
Contributor Author

Also of note, I didn't build or run this.

@tuan-hoang1
Copy link
Contributor

Hi Nikita @nikita-dubrovskii, could you help with this? Many thanks.

@nikita-dubrovskii
Copy link
Contributor

Hi Nikita @nikita-dubrovskii, could you help with this? Many thanks.

Hi, i've built FCOS this morning and installed it on zVM, system runs just fine. If you have any tests, please let me know.

[core@coreos ~]$ sudo rpm-ostree status 
State: idle
Deployments:
* ostree://fedora:fedora/s390x/coreos/testing-devel
                   Version: 32.20201111.dev.0 (2020-11-11T10:13:26Z)
                    Commit: 918fc3ea29bae10cbd5cdac1da0f24558db5270309835ab571b0acc1ca072238
              GPGSignature: (unsigned)
[core@coreos ~]$ systemctl --failed 
  UNIT LOAD ACTIVE SUB DESCRIPTION
0 loaded units listed.
[core@coreos ~]$ head /usr/lib/systemd/system/cpi.service -n18
# Service unit to apply control program identification (CPI) settings
#
# Copyright IBM Corp. 2017
#
# s390-tools is free software; you can redistribute it and/or modify
# it under the terms of the MIT license. See LICENSE for details.
#

[Unit]
Description=Apply Control Program Identification (CPI)
DefaultDependencies=no
Conflicts=shutdown.target
After=sysinit.target
ConditionPathIsReadWrite=/sys/firmware/cpi

[Service]
Type=oneshot
RemainAfterExit=yes
[core@coreos ~]$ 

@hoeppnerj
Copy link
Contributor

Thanks for testing. Also, this seems to make sense, I'll pull it.

@hoeppnerj hoeppnerj closed this in 7e832da Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants