Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for optional weight attribute's value #112

Closed
wants to merge 3 commits into from

Conversation

BShrivastav
Copy link

Fix for optional weight attr set to 0 when not provided.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #UI-21513
https://jiracloud.swg.usma.ibm.com:8443/browse/UI-21513
Output from acceptance testing:

$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISLBPoolMember_basic_opt_weight_check'
=== RUN   TestAccIBMISLBPoolMember_basic_opt_weight_check
--- PASS: TestAccIBMISLBPoolMember_basic_opt_weight_check (807.13s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc	808.130s

...

Fix for optional weight attr set to 0 when not provided.
@@ -70,7 +70,8 @@ func TestAccIBMISLBPoolMember_basic_network(t *testing.T) {
nlbName := fmt.Sprintf("tfnlbcreate%d", acctest.RandIntRange(10, 100))
nlbName1 := fmt.Sprintf("tfnlbupdate%d", acctest.RandIntRange(10, 100))

sshname := "terraform-test-ssh-key"
// sshname := "terraform-test-ssh-key"
sshname := "ssh-test-bhavesh"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generate a new suffix to 'ssh-key' instead of using name. refer other test files for it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I will revert this is to existing.

weight default info added in docs.
@BShrivastav
Copy link
Author

IBM-Cloud#3684 Upstream raised, closing internal.

@BShrivastav BShrivastav closed this May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants