Skip to content
This repository has been archived by the owner on Oct 16, 2021. It is now read-only.

Commit

Permalink
node: fix leaking Context handle
Browse files Browse the repository at this point in the history
The call to node::Environment::GetCurrent(Isolate*) makes the call to
v8::Isolate::GetCurrentContext(). Doing so creates a new handle that
bubbled to the v8::SealHandleScope().

PR-URL: nodejs/node#3945
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James Snell <jasnell@gmail.com>
  • Loading branch information
trevnorris authored and jBarz committed Nov 4, 2016
1 parent b5571c6 commit 6cd82cd
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3177,6 +3177,7 @@ static void EnableDebug(Environment* env) {

// Called from the main thread.
static void DispatchDebugMessagesAsyncCallback(uv_async_t* handle) {
HandleScope scope(node_isolate);
if (debugger_running == false) {
fprintf(stderr, "Starting debugger agent.\n");

Expand Down

0 comments on commit 6cd82cd

Please sign in to comment.