This repository has been archived by the owner on Oct 16, 2021. It is now read-only.
Add s390/s390x Linux support to Node v6.x (v2) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
gibfahn
changed the title
gibfahn
force-pushed
the
v6.0.0-proposal-port
branch
from
f141442 to
72c6e98
Compare
gibfahn
force-pushed
the
v6.0.0-proposal-port
branch
from
72c6e98 to
8d9174e
Compare
| v8_parent_path + '/tools/logreader', | ||
| v8_parent_path + '/tools/tickprocessor', | ||
| v8_parent_path + '/tools/SourceMap', | ||
| v8_parent_path + '/tools/tickprocessor-driver' |
There was a problem hiding this comment.
Need to declare and assign v8_parent_path -- see https://github.com/ibmruntimes/node/blob/v4.x-port/lib/internal/v8_prof_processor.js#L2
Since deps/v8 doesn't currently support s390/s390x, pick up deps/v8z instead. Based on afe84b8 modified: common.gypi modified: configure modified: lib/internal/v8_prof_processor.js modified: node.gyp
gibfahn
force-pushed
the
v6.0.0-proposal-port
branch
6 times, most recently
from
e618d9c to
8681767
Compare
Import from ibmruntimes/v8z branch 5.0-s390 bcb22c907a Node PR: nodejs#6111 Files removed from 5.0-s390: CONTRIBUTING.md .DEPS.git .git Also added deps/v8z/base/trace_event/common/trace_event_common.h and removed /base from deps/v8z/.gitignore
gibfahn
force-pushed
the
v6.0.0-proposal-port
branch
from
8681767 to
c68da99
Compare
Node PR: nodejs#6218 Commit: af4a380
Node PR: nodejs#6179 Commit: a11d506
gibfahn
force-pushed
the
v6.0.0-proposal-port
branch
from
036de2a to
6e8bba4
Compare
Node PR: nodejs#6267 Commit: 0899ea7
V8z commit: da254cc29d5feb44fe14a431e7912ab95c12147c
jBarz
pushed a commit
that referenced
this pull request
May 11, 2017
Original commit message: Merged: [heap] Clear recorded slots for inobject properties when migrating fast object to slow mode. Revision: a814b8aeaf2b56635054c96435972dce90576f62 BUG=chromium:666046 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=ulan@chromium.org Review URL: https://codereview.chromium.org/2549803002 . Cr-Commit-Position: refs/branch-heads/5.5@{#60} Cr-Branched-From: 3cbd5838bd8376103daa45d69dade929ee4e0092-refs/heads/5.5.372@{#1} Cr-Branched-From: b3c8b0ce2c9af0528837d8309625118d4096553b-refs/heads/master@{#40015} PR-URL: nodejs/node#10733 Reviewed-By: Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: mhdawson - Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since deps/v8 doesn't currently support s390/s390x, pick up deps/v8z instead.
Based on #58 (can't change base branch in PRs)
Based on afe84b8
modified: common.gypi
modified: configure
modified: lib/internal/v8_prof_processor.js
modified: node.gyp