Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openssl thread synchronization to fix crashes #185

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

shanchao95
Copy link
Contributor

Openssl 1.0.2 is not safely used in multi-thread application.
The change adds threadid and locking callback functions to provide
thread-safety when openssl 1.0.2 is used. It fixes issue 8373,
test crash in openjdk, jdk_net_0,
com/sun/net/httpserver/Test9a.java

Signed-off-by: Chao Shan chao.shan@ibm.com

@shanchao95
Copy link
Contributor Author

@keithc-ca Code updated

@shanchao95
Copy link
Contributor Author

@keithc-ca Code updated.

Copy link
Member

@keithc-ca keithc-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the missing space after if on line 1312.

@shanchao95 shanchao95 force-pushed the new_issue_8373 branch 2 times, most recently from 30e94ec to d6b34b8 Compare April 1, 2020 19:09
@keithc-ca
Copy link
Member

Jenkins compile aix,osx jdknext

@keithc-ca
Copy link
Member

Jenkins compile aix,osx,win jdknext

Openssl 1.0.2 is not safely used in multi-thread application.
The change adds threadid and locking callback functions to provide
thread-safety when openssl 1.0.2 is used. It fixes issue 8373,
test crash in openjdk, jdk_net_0,
com/sun/net/httpserver/Test9a.java

Signed-off-by: Chao Shan <chao.shan@ibm.com>
@keithc-ca
Copy link
Member

@keithc-ca keithc-ca merged commit 1323bd7 into ibmruntimes:openj9 Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants