-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openssl thread synchronization to fix crashes #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@keithc-ca Code updated |
shanchao95
force-pushed
the
new_issue_8373
branch
from
April 1, 2020 15:21
849faa2
to
aa7a9c1
Compare
@keithc-ca Code updated. |
keithc-ca
requested changes
Apr 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the missing space after if
on line 1312.
shanchao95
force-pushed
the
new_issue_8373
branch
2 times, most recently
from
April 1, 2020 19:09
30e94ec
to
d6b34b8
Compare
Jenkins compile aix,osx jdknext |
shanchao95
force-pushed
the
new_issue_8373
branch
from
April 6, 2020 15:25
d6b34b8
to
0ffde83
Compare
Jenkins compile aix,osx,win jdknext |
Openssl 1.0.2 is not safely used in multi-thread application. The change adds threadid and locking callback functions to provide thread-safety when openssl 1.0.2 is used. It fixes issue 8373, test crash in openjdk, jdk_net_0, com/sun/net/httpserver/Test9a.java Signed-off-by: Chao Shan <chao.shan@ibm.com>
shanchao95
force-pushed
the
new_issue_8373
branch
from
April 6, 2020 18:44
0ffde83
to
a5fc57e
Compare
https://ci.eclipse.org/openj9/view/Pull%20Requests/job/PullRequest-OpenJDKnext/31 should still be valid. |
keithc-ca
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openssl 1.0.2 is not safely used in multi-thread application.
The change adds threadid and locking callback functions to provide
thread-safety when openssl 1.0.2 is used. It fixes issue 8373,
test crash in openjdk, jdk_net_0,
com/sun/net/httpserver/Test9a.java
Signed-off-by: Chao Shan chao.shan@ibm.com