Add openssl thread synchronization to fix crashes #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keithc-ca code updated |
keithc-ca
requested changes
Mar 25, 2020
shanchao95
force-pushed
the
new_issue_8373
branch
from
acf9c15
to
1ad5ea6
Compare
keithc-ca
reviewed
Mar 26, 2020
shanchao95
force-pushed
the
new_issue_8373
branch
2 times, most recently
from
ce8de7c
to
475567d
Compare
|
@keithc-ca Code updated |
keithc-ca
reviewed
Mar 30, 2020
shanchao95
force-pushed
the
new_issue_8373
branch
from
475567d
to
ec72993
Compare
|
@keithc-ca Code updated, I'll update jdk14 and next if jdk11 is ok. |
|
Jenkins test sanity.openjdk aix,osx,win,xlinux jdk11 |
|
The xlinux failures appear to be eclipse-openj9/openj9#8899. |
|
@shanchao95 A gentle reminder that this awaits similar updates to jdk14 and jdknext. |
shanchao95
force-pushed
the
new_issue_8373
branch
from
ec72993
to
b34e17c
Compare
|
Jenkins test sanity.openjdk aix,osx,win,xlinux jdk11 |
Openssl 1.0.2 is not safely used in multi-thread application. The change adds threadid and locking callback functions to provide thread-safety when openssl 1.0.2 is used. It fixes issue 8373, test crash in openjdk, jdk_net_0, com/sun/net/httpserver/Test9a.java Signed-off-by: Chao Shan <chao.shan@ibm.com>
shanchao95
force-pushed
the
new_issue_8373
branch
from
b34e17c
to
0d5410f
Compare
|
https://ci.eclipse.org/openj9/view/Pull%20Requests/job/PullRequest-OpenJDK11/92 should still be valid. |
keithc-ca
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openssl 1.0.2 is not safely used in multi-thread application.
The change adds threadid and locking callback functions to provide
thread-safety when openssl 1.0.2 is used. It fixes issue 8373,
test crash in openjdk, jdk_net_0,
com/sun/net/httpserver/Test9a.java
Signed-off-by: Chao Shan chao.shan@ibm.com