This repository has been archived by the owner on Oct 22, 2020. It is now read-only.
Fixing failing OutputSizeTest #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Apr 9, 2020
closed/src/java.base/share/classes/com/sun/crypto/provider/NativeChaCha20Cipher.java
Outdated
Show resolved
Hide resolved
|
Pls update the IBM copyright end date. |
|
@pshipton I addressed the comments above |
keithc-ca
suggested changes
Apr 13, 2020
closed/src/java.base/share/classes/com/sun/crypto/provider/NativeChaCha20Cipher.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/com/sun/crypto/provider/NativeChaCha20Cipher.java
Show resolved
Hide resolved
closed/src/java.base/share/classes/com/sun/crypto/provider/NativeChaCha20Cipher.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/com/sun/crypto/provider/NativeChaCha20Cipher.java
Outdated
Show resolved
Hide resolved
closed/src/java.base/share/classes/com/sun/crypto/provider/NativeChaCha20Cipher.java
Outdated
Show resolved
Hide resolved
|
@keithc-ca Thanks for the review. I addressed those changes. Please let me know if you prefer I merge the new commits on this branch into one. |
Yes, I think now is a good time to squash. Please also prepare equivalent pull requests for jdk11 and jdknext. |
* Changing the ChaCha20 AEAD decryption implementation of getOutputSize() * getOutputSize() must take into consideration the unprocessed input Signed-off-by: Samer AL Masri <samasri@ibm.com>
|
jenkins test sanity.openjdk osx,win jdk14 |
keithc-ca
approved these changes
Apr 15, 2020
|
@pshipton Please approve if this looks good to you. |
pshipton
approved these changes
Apr 15, 2020
Done. |
This was referenced Apr 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing OpenJ9 Issue 9079
Changed the
NativeChaCha20Cipher.getOutputSize()implementation to take into consideration the unprocessed input when returning the output size in AEAD ChaCha20 decryption.Signed-off-by: Samer AL Masri samasri@ibm.com