Correct padding of struct layouts #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
I've verified this PR (only involves the test code) via Grinders at https://openj9-jenkins.osuosl.org/job/Grinder/1787/console on all supported platforms with all foreign-related jtreg test suites enabled in JDK17 at ChengJin01/aqa-tests@c9d4213#diff-a5bebf2d9c9f465d654db2bd952ac7e529903273ff5be89d00266afa96de08fd, which works good as expected. |
|
Please help forward-port this PR to JDK19 & JDKnext at https://github.com/ibmruntimes/openj9-openjdk-jdk19/blob/openj9/test/jdk/java/foreign/CallGeneratorHelper.java#L149 and https://github.com/ibmruntimes/openj9-openjdk-jdk/blob/openj9/test/jdk/java/foreign/CallGeneratorHelper.java#L149 given the calculation of the struct layout should remain the same regardless of java versions. |
pshipton
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of padding elements in structure layouts should be
alignment - (offset % alignment)bits wide (whenoffsetis not a multiple ofalignment).See #166 (review); in draft mode pending testing results. FYI @ChengJin01.