Simplify and improve module dependency management #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the rules to preprocess OpenJ9 source files to Main-post.gmk so module-deps.gmk can depend those actions. This also ensures that module dependencies are updated in incremental builds as appropriate. Remove an unnecessary include of JPP.gmk in OpenJ9.gmk. Move definition of J9JCL_SOURCES_DONEFILE to Main-post.gmk, which is now the only place it's used. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
pshipton
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the rules to preprocess OpenJ9 source files to
Main-post.gmksomodule-deps.gmkcan depend those actions. This also ensures that module dependencies are updated in incremental builds as appropriate.Remove an unnecessary include of
JPP.gmkinOpenJ9.gmk.Move definition of
J9JCL_SOURCES_DONEFILEtoMain-post.gmk, which is now the only place it's used.This is a back-port of ibmruntimes/openj9-openjdk-jdk#797.