Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable FIPS140-3 failures #369

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Re-enable FIPS140-3 failures #369

merged 1 commit into from
Aug 2, 2024

Conversation

JinhangZhang
Copy link
Contributor

No description provided.

@JinhangZhang
Copy link
Contributor Author

@llxia @jasonkatonica As discussed, re-enable update where test ignores were removed in #367.

@JinhangZhang JinhangZhang marked this pull request as draft July 30, 2024 06:32
@JinhangZhang JinhangZhang marked this pull request as ready for review July 30, 2024 19:34
@llxia
Copy link
Contributor

llxia commented Aug 1, 2024

@JinhangZhang I noticed com/sun/jdi/JdwpAttachTest.java.JdwpAttachTest https://github.com/ibmruntimes/openj9-openjdk-jdk17/issues/321 linux-x64,linux-ppc64le,linux-s390x,aix-all was added in https://github.com/ibmruntimes/openj9-openjdk-jdk17/pull/367/files, but it is not in this PR. It is expected?

@JinhangZhang
Copy link
Contributor Author

It is in

openj9-openjdk-jdk17/test/jdk/ProblemList-FIPS140_3_OpenJcePlus.txt

Line 929 in 25d1ee8

com/sun/jdi/JdwpAttachTest.java.JdwpAttachTest https://github.com/ibmruntimes/openj9-openjdk-jdk17/issues/321 linux-x64,linux-ppc64le,linux-s390x,aix-all

@JinhangZhang I noticed com/sun/jdi/JdwpAttachTest.java.JdwpAttachTest https://github.com/ibmruntimes/openj9-openjdk-jdk17/issues/321 linux-x64,linux-ppc64le,linux-s390x,aix-all was added in https://github.com/ibmruntimes/openj9-openjdk-jdk17/pull/367/files, but it is not in this PR. It is expected?

@jasonkatonica
Copy link
Contributor

These updates look reasonable to me.

@JinhangZhang
Copy link
Contributor Author

@JasonFengJ9 Please help to merge

@JasonFengJ9 JasonFengJ9 merged commit 68c5891 into ibmruntimes:openj9 Aug 2, 2024
2 checks passed
@JinhangZhang JinhangZhang mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonFengJ9 JasonFengJ9 JasonFengJ9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JinhangZhang @llxia @jasonkatonica @JasonFengJ9