Add openssl thread synchronization to fix crashes #381

shanchao95 · 2020-03-05T15:15:04Z

Openssl 1.0.2 is not safely used in multi-thread application.
The change adds threadid and locking callback functions to provide
thread-safety when openssl 1.0.2 is used. It fixes issue eclipse-openj9/openj9#8373,
test crash in openjdk, jdk_net_0,
com/sun/net/httpserver/Test9a.java

shanchao95 · 2020-03-05T15:19:31Z

eclipse-openj9/openj9#8373

pshipton · 2020-03-05T16:43:39Z

Pls create a better commit comment. https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53

Although it may be too long for the commit summary, the body should mention the full context of the test: openjdk jdk_net_0 com/sun/net/httpserver/Test9a.java

The copyright check is failing, the IBM copyright end date should be 2020.

closed/adds/jdk/src/share/native/jdk/crypto/jniprovider/NativeCrypto.c

shanchao95 · 2020-03-10T20:27:06Z

@pshipton Thanks, the code is updated.

For checking malloc results, is stderr a proper response for failure, or i should use unload_crypto_library() to response.

pshipton · 2020-03-10T21:06:28Z

Calling unload_crypto_library() and returning -1 from the loadCrypto native is appropriate.

shanchao95 · 2020-03-12T17:01:17Z

@pshipton The code is updated.

unload_crypto_library() and return -1 if malloc fails.
add modification for Windows, because Windows has different implementation with Linux for the change. Only modifying Linux-ppc does not compile on Windows
After adding Windows modification, the code compiles successfully on Windows. but have not tested code for test sanity.openjdk. tried to test it on Grinder, got an error exec] gzip: jtreg-4.2.0-tip.tar.gz: not in gzip format during tests building process. https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/6539/console
compile and test passed on Windows
Compile: https://hyc-runtimes-jenkins.swg-devops.com/view/Java8/job/Build_JDK8_x86-64_windows_Personal/388/
Tests: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/6559/

pshipton · 2020-03-12T19:41:01Z

jenkins test sanity.openjdk win,win32,xlinux,plinux,zlinux,aix,osx jdk8

pshipton · 2020-03-12T19:44:31Z

I've started a cross platform test.

Note the commit comment needs to be updated, see https://chris.beams.io/posts/git-commit/
In particular the part If applied, this commit will "your subject line here"

pshipton · 2020-03-13T15:11:05Z

There are some "Access is denied" failures, although they may occur before these changes. I'll run a build to check.
https://ci.eclipse.org/openj9/job/Test_openjdk8_j9_sanity.openjdk_x86-32_windows_Personal/2/testReport/
https://ci.eclipse.org/openj9/job/Test_openjdk8_j9_sanity.openjdk_x86-64_windows_Personal/2/testReport/

Build without these changes to check Windows failures.
https://ci.eclipse.org/openj9/view/Pipelines/job/Pipeline-Release-Build/174/

pshipton · 2020-03-13T15:11:59Z

plinux didn't successfully start the testing, try it again (edit: it passed on restart)

jenkins test sanity.openjdk plinux jdk8

pshipton · 2020-03-13T17:56:47Z

The build without these changes has the same Windows failures.
https://ci.eclipse.org/openj9/job/Test_openjdk8_j9_sanity.openjdk_x86-64_windows_Personal/3/testReport/

closed/adds/jdk/src/share/native/jdk/crypto/jniprovider/NativeCrypto.c

pshipton · 2020-03-17T17:17:00Z

The plinux sanity.openjdk run passed (on ub16p8j91), but I'll try more runs to ensure the problem is gone.
https://ci.eclipse.org/openj9/view/Test/job/Grinder/689 - ub16p8j95
https://ci.eclipse.org/openj9/view/Test/job/Grinder/690 - ub16-ppcle-3
https://ci.eclipse.org/openj9/view/Test/job/Grinder/691 - ub16p8j93
https://ci.eclipse.org/openj9/view/Test/job/Grinder/692 - ub16p8j91
https://ci.eclipse.org/openj9/view/Test/job/Grinder/693 - ub16-ppcle-2

These all passed.

alon-sh · 2020-03-19T20:59:57Z

FYI @pshipton @keithc-ca code updated

closed/adds/jdk/src/share/native/jdk/crypto/jniprovider/NativeCrypto.c

shanchao95 · 2020-03-20T19:14:19Z

@keithc-ca code updated

closed/adds/jdk/src/share/native/jdk/crypto/jniprovider/NativeCrypto.c

keithc-ca · 2020-03-24T19:44:32Z

Jenkins test sanity.openjdk plinux,win,win32 jdk8

keithc-ca · 2020-03-25T14:21:09Z

The test failure seems unrelated to this. Unfortunately no core files were included in the test output archive.

17:03:29  ===============================================
17:03:29  Running test jdk_util_0 ...
17:03:29  ===============================================
17:03:29  jdk_util_0 Start Time: Tue Mar 24 17:03:28 2020 Epoch Time (ms): 1585083808890
17:03:29  "/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdkbinary/j2sdk-image/bin/java" -Xshareclasses:destroyAll; "/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdkbinary/j2sdk-image/bin/java" -Xshareclasses:groupAccess,destroyAll; echo "cache cleanup done";
17:03:29  JVMSHRC005I No shared class caches available
17:03:29  JVMSHRC005I No shared class caches available
17:03:29  cache cleanup done
17:03:29  variation: NoOptions
17:03:29  JVM_OPTIONS: -Xcompressedrefs 
17:03:29  { itercnt=1; \
17:03:29  mkdir -p "/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/../TKG/test_output_1585082508650/jdk_util_0"; \
17:03:29  cd "/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/../TKG/test_output_1585082508650/jdk_util_0"; \
17:03:29  "/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdkbinary/j2sdk-image/bin/java" -Xmx512m -jar "/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/../../jvmtest/openjdk/jtreg/lib/jtreg.jar" \
17:03:29  -agentvm -a -ea -esa -v:fail,error,time,nopass -retain:fail,error,*.dmp,javacore.*,heapdump.*,*.trc -ignore:quiet -timeoutFactor:8 -xml:verify -concurrency:3 -vmoptions:"-Xmx512m -Xcompressedrefs " \
17:03:29  -w ""/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/../TKG/test_output_1585082508650/jdk_util_0"/work" \
17:03:29  -r "/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/../../jvmtest/openjdk/report" \
17:03:29  -jdk:"/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdkbinary/j2sdk-image" \
17:03:29  -exclude:"/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/../openjdk/openjdk-jdk/jdk/test/ProblemList.txt" \
17:03:29  -exclude:"/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/../../jvmtest/openjdk/ProblemList_openjdk8-openj9.txt" \
17:03:29  "/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/../openjdk/openjdk-jdk/jdk/test:jdk_util"; \
17:03:29  if [ $? -eq 0 ] ; then echo ""; echo "jdk_util_0""_PASSED"; echo ""; cd /home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/..;  else echo ""; echo "jdk_util_0""_FAILED"; echo ""; fi; } 2>&1 | tee -a "/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/../TKG/test_output_1585082508650/TestTargetResult";
17:03:29  Directory "/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/../TKG/test_output_1585082508650/jdk_util_0/work" not found: creating
17:03:30  XML output with verification to /home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/test_output_1585082508650/jdk_util_0/work
17:06:38  [2020-03-24 17:06:38,421] Agent[1]: stderr: Unhandled exception
17:06:38  [2020-03-24 17:06:38,422] Agent[1]: stderr: Type=Segmentation error vmState=0x00020011
17:06:38  [2020-03-24 17:06:38,422] Agent[1]: stderr: J9Generic_Signal_Number=00000018 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000001
17:06:38  [2020-03-24 17:06:38,422] Agent[1]: stderr: Handler1=00003FFF9E707FF0 Handler2=00003FFF9E597180
17:06:38  [2020-03-24 17:06:38,422] Agent[1]: stderr: R0=00003FFF9D3649EC R1=00003FFF9F09CDB0 R2=00003FFF9DF19300 R3=00003FFF97EF6120
17:06:38  [2020-03-24 17:06:38,422] Agent[1]: stderr: R4=00003FFF9F09CE60 R5=00003FFF980EE660 R6=00003FFF980EE660 R7=00003FFF700FE7E0
17:06:38  [2020-03-24 17:06:38,423] Agent[1]: stderr: R8=00003FFF980D2548 R9=0000000000000000 R10=0000000000000000 R11=0000000100000000
17:06:38  [2020-03-24 17:06:38,423] Agent[1]: stderr: R12=00003FFF9F40D1D0 R13=00003FFF9F0A6900 R14=0000000000000007 R15=0000000000000004
17:06:38  [2020-03-24 17:06:38,423] Agent[1]: stderr: R16=00003FFF98048F40 R17=00003FFF9F09D57F R18=0000000000000006 R19=0000000000020019
17:06:38  [2020-03-24 17:06:38,423] Agent[1]: stderr: R20=0000000000000000 R21=00003FFF9E898330 R22=0005A1A020AA406B R23=00003FFF9D364878
17:06:38  [2020-03-24 17:06:38,423] Agent[1]: stderr: R24=00003FFF98012238 R25=00003FFF9DF4CDC0 R26=00003FFF97EF6120 R27=00003FFF97EF6318
17:06:38  [2020-03-24 17:06:38,423] Agent[1]: stderr: R28=0000000000000000 R29=00003FFF97EF6160 R30=00003FFF9F09CE60 R31=00003FFF480268C0
17:06:38  [2020-03-24 17:06:38,423] Agent[1]: stderr: NIP=00003FFF9D342574 MSR=800000010280F033 ORIG_GPR3=00000000000081C8 CTR=00003FFF9F40D1D0
17:06:38  [2020-03-24 17:06:38,423] Agent[1]: stderr: LINK=00003FFF9D3649EC XER=0000000000000000 CCR=0000000028004224 SOFTE=0000000000000001
17:06:38  [2020-03-24 17:06:38,423] Agent[1]: stderr: TRAP=0000000000000300 DAR=0000000000000000 dsisr=0000000040000000 RESULT=0000000000000000
17:06:38  [2020-03-24 17:06:38,423] Agent[1]: stderr: FPR0 00003fff9e896f08 (f: 2659806976.000000, d: 3.476597e-310)
17:06:38  [2020-03-24 17:06:38,423] Agent[1]: stderr: FPR1 4050111d20000000 (f: 536870912.000000, d: 6.426740e+01)
17:06:38  [2020-03-24 17:06:38,423] Agent[1]: stderr: FPR2 3f847ae147ae147b (f: 1202590848.000000, d: 1.000000e-02)
17:06:38  [2020-03-24 17:06:38,423] Agent[1]: stderr: FPR3 3fee666660000000 (f: 1610612736.000000, d: 9.500000e-01)
17:06:38  [2020-03-24 17:06:38,424] Agent[1]: stderr: FPR4 3f499a0000000000 (f: 0.000000, d: 7.812977e-04)
17:06:38  [2020-03-24 17:06:38,424] Agent[1]: stderr: FPR5 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,424] Agent[1]: stderr: FPR6 61656c43746f6f52 (f: 1953460096.000000, d: 1.505934e+161)
17:06:38  [2020-03-24 17:06:38,424] Agent[1]: stderr: FPR7 696b72614d2f6176 (f: 1294950784.000000, d: 6.565364e+199)
17:06:38  [2020-03-24 17:06:38,424] Agent[1]: stderr: FPR8 bfa0eec4c0000000 (f: 3221225472.000000, d: -3.307166e-02)
17:06:38  [2020-03-24 17:06:38,424] Agent[1]: stderr: FPR9 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,424] Agent[1]: stderr: FPR10 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,424] Agent[1]: stderr: FPR11 41cdcd6500000000 (f: 0.000000, d: 1.000000e+09)
17:06:38  [2020-03-24 17:06:38,424] Agent[1]: stderr: FPR12 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,425] Agent[1]: stderr: FPR13 bfb7440000000000 (f: 0.000000, d: -9.088135e-02)
17:06:38  [2020-03-24 17:06:38,425] Agent[1]: stderr: FPR14 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,425] Agent[1]: stderr: FPR15 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,425] Agent[1]: stderr: FPR16 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,425] Agent[1]: stderr: FPR17 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,425] Agent[1]: stderr: FPR18 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,425] Agent[1]: stderr: FPR19 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,425] Agent[1]: stderr: FPR20 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,425] Agent[1]: stderr: FPR21 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,425] Agent[1]: stderr: FPR22 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,426] Agent[1]: stderr: FPR23 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,426] Agent[1]: stderr: FPR24 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,427] Agent[1]: stderr: FPR25 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,427] Agent[1]: stderr: FPR26 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,427] Agent[1]: stderr: FPR27 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,428] Agent[1]: stderr: FPR28 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,428] Agent[1]: stderr: FPR29 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,429] Agent[1]: stderr: FPR30 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,429] Agent[1]: stderr: FPR31 0000000000000000 (f: 0.000000, d: 0.000000e+00)
17:06:38  [2020-03-24 17:06:38,429] Agent[1]: stderr: Module=/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdkbinary/j2sdk-image/jre/lib/ppc64le/compressedrefs/libj9jit29.so
17:06:38  [2020-03-24 17:06:38,429] Agent[1]: stderr: Module_base_address=00003FFF9D1F0000
17:06:38  [2020-03-24 17:06:38,430] Agent[1]: stderr: Target=2_90_20200324_768 (Linux 4.4.0-173-generic)
17:06:38  [2020-03-24 17:06:38,430] Agent[1]: stderr: CPU=ppc64le (16 logical CPUs) (0x1fe090000 RAM)
17:06:38  [2020-03-24 17:06:38,430] Agent[1]: stderr: ----------- Stack Backtrace -----------
17:06:38  [2020-03-24 17:06:38,430] Agent[1]: stderr: (0x00003FFF9D342574 [libj9jit29.so+0x152574])
17:06:38  [2020-03-24 17:06:38,430] Agent[1]: stderr: (0x00003FFF9F09CE00 [<unknown>+0x0])
17:06:38  [2020-03-24 17:06:38,431] Agent[1]: stderr: (0x00003FFF9D3649EC [libj9jit29.so+0x1749ec])
17:06:38  [2020-03-24 17:06:38,431] Agent[1]: stderr: (0x00003FFF9E611800 [libj9hookable29.so+0x1800])
17:06:38  [2020-03-24 17:06:38,431] Agent[1]: stderr: (0x00003FFF9D11B134 [libj9gc29.so+0x25b134])
17:06:38  [2020-03-24 17:06:38,431] Agent[1]: stderr: (0x00003FFF9D093AA8 [libj9gc29.so+0x1d3aa8])
17:06:38  [2020-03-24 17:06:38,431] Agent[1]: stderr: (0x00003FFF9D093D28 [libj9gc29.so+0x1d3d28])
17:06:38  [2020-03-24 17:06:38,431] Agent[1]: stderr: (0x00003FFF9D09FCAC [libj9gc29.so+0x1dfcac])
17:06:38  [2020-03-24 17:06:38,431] Agent[1]: stderr: (0x00003FFF9D0F9B2C [libj9gc29.so+0x239b2c])
17:06:38  [2020-03-24 17:06:38,431] Agent[1]: stderr: (0x00003FFF9D02956C [libj9gc29.so+0x16956c])
17:06:38  [2020-03-24 17:06:38,431] Agent[1]: stderr: (0x00003FFF9D0FFE30 [libj9gc29.so+0x23fe30])
17:06:38  [2020-03-24 17:06:38,431] Agent[1]: stderr: (0x00003FFF9D102608 [libj9gc29.so+0x242608])
17:06:38  [2020-03-24 17:06:38,431] Agent[1]: stderr: (0x00003FFF9D102C9C [libj9gc29.so+0x242c9c])
17:06:38  [2020-03-24 17:06:38,431] Agent[1]: stderr: (0x00003FFF9D03B2C4 [libj9gc29.so+0x17b2c4])
17:06:38  [2020-03-24 17:06:38,432] Agent[1]: stderr: (0x00003FFF9D097DAC [libj9gc29.so+0x1d7dac])
17:06:38  [2020-03-24 17:06:38,432] Agent[1]: stderr: (0x00003FFF9CF1AEDC [libj9gc29.so+0x5aedc])
17:06:38  [2020-03-24 17:06:38,432] Agent[1]: stderr: (0x00003FFF9DC52BC0 [libj9jit29.so+0xa62bc0])
17:06:38  [2020-03-24 17:06:38,432] Agent[1]: stderr: (0x00003FFF9DC6B890 [libj9jit29.so+0xa7b890])
17:06:38  [2020-03-24 17:06:38,432] Agent[1]: stderr: (0x00003FFF9E6F0468 [libj9vm29.so+0x90468])
17:06:38  [2020-03-24 17:06:38,432] Agent[1]: stderr: (0x00003FFF9E70CFC0 [libj9vm29.so+0xacfc0])
17:06:38  [2020-03-24 17:06:38,432] Agent[1]: stderr: (0x00003FFF9E76A1C8 [libj9vm29.so+0x10a1c8])
17:06:38  [2020-03-24 17:06:38,432] Agent[1]: stderr: (0x00003FFF9E598588 [libj9prt29.so+0x28588])
17:06:38  [2020-03-24 17:06:38,432] Agent[1]: stderr: (0x00003FFF9E76A29C [libj9vm29.so+0x10a29c])
17:06:38  [2020-03-24 17:06:38,432] Agent[1]: stderr: (0x00003FFF9E70F9A0 [libj9vm29.so+0xaf9a0])
17:06:38  [2020-03-24 17:06:38,432] Agent[1]: stderr: (0x00003FFF9E70C5D8 [libj9vm29.so+0xac5d8])
17:06:38  [2020-03-24 17:06:38,432] Agent[1]: stderr: (0x00003FFF9F3C9CA4 [libjli.so+0x9ca4])
17:06:38  [2020-03-24 17:06:38,432] Agent[1]: stderr: (0x00003FFF9F408040 [libpthread.so.0+0x8040])
17:06:38  [2020-03-24 17:06:38,433] Agent[1]: stderr: clone+0x98 (0x00003FFF9F2E3BB0 [libc.so.6+0x123bb0])
17:06:38  [2020-03-24 17:06:38,433] Agent[1]: stderr: ---------------------------------------
17:06:38  [2020-03-24 17:06:38,433] Agent[1]: stderr: JVMDUMP039I Processing dump event "gpf", detail "" at 2020/03/24 17:06:38 - please wait.
17:06:38  [2020-03-24 17:06:38,435] Agent[1]: stderr: JVMDUMP032I JVM requested System dump using '/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/test_output_1585082508650/jdk_util_0/work/scratch/1/core.20200324.170638.1269.0001.dmp' in response to an event
17:06:40  [2020-03-24 17:06:40,544] Agent[1]: stderr: JVMPORT030W /proc/sys/kernel/core_pattern setting "|/usr/share/apport/apport %p %s %c %d %P" specifies that the core dump is to be piped to an external program.  Attempting to rename either core or core.2505.
17:06:40  [2020-03-24 17:06:40,545] Agent[1]: stderr: 
17:06:41  [2020-03-24 17:06:40,690] Agent[1]: stderr: JVMDUMP010I System dump written to /home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/test_output_1585082508650/jdk_util_0/work/scratch/1/core.20200324.170638.1269.0001.dmp
17:06:41  [2020-03-24 17:06:41,009] Agent[1]: stderr: JVMDUMP032I JVM requested Java dump using '/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/test_output_1585082508650/jdk_util_0/work/scratch/1/javacore.20200324.170638.1269.0002.txt' in response to an event
17:06:44  [2020-03-24 17:06:43,887] Agent[1]: stderr: JVMDUMP010I Java dump written to /home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/test_output_1585082508650/jdk_util_0/work/scratch/1/javacore.20200324.170638.1269.0002.txt
17:06:44  [2020-03-24 17:06:43,887] Agent[1]: stderr: JVMDUMP032I JVM requested Snap dump using '/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/test_output_1585082508650/jdk_util_0/work/scratch/1/Snap.20200324.170638.1269.0003.trc' in response to an event
17:06:44  [2020-03-24 17:06:43,988] Agent[1]: stderr: JVMDUMP010I Snap dump written to /home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/test_output_1585082508650/jdk_util_0/work/scratch/1/Snap.20200324.170638.1269.0003.trc
17:06:44  [2020-03-24 17:06:43,991] Agent[1]: stderr: JVMDUMP007I JVM Requesting JIT dump using '/home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/test_output_1585082508650/jdk_util_0/work/scratch/1/jitdump.20200324.170638.1269.0004.dmp'
17:06:44  [2020-03-24 17:06:43,991] Agent[1]: stderr: JVMDUMP010I JIT dump written to /home/jenkins/workspace/Test_openjdk8_j9_sanity.openjdk_ppc64le_linux_Personal/openjdk-tests/TKG/test_output_1585082508650/jdk_util_0/work/scratch/1/jitdump.20200324.170638.1269.0004.dmp
17:06:44  [2020-03-24 17:06:43,994] Agent[1]: stderr: JVMDUMP013I Processed dump event "gpf", detail "".
17:06:44  --------------------------------------------------

keithc-ca · 2020-03-25T14:22:25Z

@shanchao95 I think this is good. Would you please put together equivalent pull requests for jdk11, jdk14 and jdk(next).

pshipton · 2020-03-25T14:54:17Z

The test failure #381 (comment) is likely a dup of eclipse-openj9/openj9#8652

closed/adds/jdk/src/share/native/jdk/crypto/jniprovider/NativeCrypto.c

keithc-ca · 2020-03-30T13:02:45Z

Jenkins test sanity.openjdk xlinux,win,win32 jdk8

keithc-ca · 2020-03-30T17:16:20Z

The xlinux failures appear to be eclipse-openj9/openj9#8899.

keithc-ca · 2020-04-06T15:45:51Z

Jenkins test sanity.openjdk xlinux,win32 jdk8

keithc-ca · 2020-04-06T17:40:24Z

@ashbm5 @pshipton Any final comments before this is merged?

pshipton · 2020-04-06T17:45:11Z

I'd also like PRs opened against the openj9-0.20.0 branches for the 0.20.0 release, although we can wait a couple days for these changes to soak in the head stream before merging them.

closed/adds/jdk/src/share/native/jdk/crypto/jniprovider/NativeCrypto.c

Openssl 1.0.2 is not safely used in multi-thread application. The change adds threadid and locking callback functions to provide thread-safety when openssl 1.0.2 is used. It fixes issue 8373, test crash in openjdk, jdk_net_0, com/sun/net/httpserver/Test9a.java Signed-off-by: Chao Shan <chao.shan@ibm.com>

shanchao95 · 2020-04-06T18:34:07Z

@keithc-ca code updated

keithc-ca · 2020-04-06T19:36:02Z

Jenkins compile xlinux,win32 jdk8

ashu-mehra · 2020-04-06T22:21:02Z

closed/adds/jdk/src/share/native/jdk/crypto/jniprovider/NativeCrypto.c

+        if (NULL == lock_cs[i]) {
+            fprintf(stderr, "CreateMutex error: %d\n", GetLastError());
+            for (j = 0; j < i; j++) {
+                BOOL releaseResult = ReleaseMutex(lock_cs[j]);


The intialOwner parameter of CreateMutex() was passed FALSE, so we don't need to call ReleaseMutex here, instead we should call CloseHandle as we do in JNI_OnUnLoad().

Yes, I think you're right. I'll open PRs to fix that.

pshipton reviewed Mar 5, 2020

View reviewed changes

shanchao95 force-pushed the new_issue_8373 branch 2 times, most recently from 260b179 to e352b52 Compare March 10, 2020 19:22

shanchao95 force-pushed the new_issue_8373 branch 3 times, most recently from 334b453 to 0cc044c Compare March 12, 2020 16:46

pshipton requested a review from keithc-ca March 13, 2020 17:56

keithc-ca requested changes Mar 17, 2020

View reviewed changes

shanchao95 force-pushed the new_issue_8373 branch from 0cc044c to ec86cd0 Compare March 19, 2020 20:17

keithc-ca requested changes Mar 19, 2020

View reviewed changes

shanchao95 force-pushed the new_issue_8373 branch from ec86cd0 to 8539995 Compare March 20, 2020 16:35

keithc-ca requested changes Mar 20, 2020

View reviewed changes

keithc-ca reviewed Mar 20, 2020

View reviewed changes

closed/adds/jdk/src/share/native/jdk/crypto/jniprovider/NativeCrypto.c Outdated Show resolved Hide resolved

shanchao95 force-pushed the new_issue_8373 branch from 8539995 to 276af02 Compare March 20, 2020 19:13

keithc-ca reviewed Mar 20, 2020

View reviewed changes

shanchao95 force-pushed the new_issue_8373 branch 2 times, most recently from 07cb847 to 005e633 Compare March 23, 2020 18:45

pshipton mentioned this pull request Mar 25, 2020

sanity.openjdk jdk_net_0 httpserver/Test9a crash libcrypto eclipse-openj9/openj9#8373

Closed

keithc-ca reviewed Mar 25, 2020

View reviewed changes

closed/adds/jdk/src/share/native/jdk/crypto/jniprovider/NativeCrypto.c Outdated Show resolved Hide resolved

shanchao95 force-pushed the new_issue_8373 branch 2 times, most recently from 4db2063 to bb98052 Compare March 26, 2020 20:19

shanchao95 force-pushed the new_issue_8373 branch from bb98052 to feeabca Compare April 6, 2020 15:08

keithc-ca approved these changes Apr 6, 2020

View reviewed changes

pshipton reviewed Apr 6, 2020

View reviewed changes

closed/adds/jdk/src/share/native/jdk/crypto/jniprovider/NativeCrypto.c Outdated Show resolved Hide resolved

keithc-ca requested changes Apr 6, 2020

View reviewed changes

closed/adds/jdk/src/share/native/jdk/crypto/jniprovider/NativeCrypto.c Outdated Show resolved Hide resolved

closed/adds/jdk/src/share/native/jdk/crypto/jniprovider/NativeCrypto.c Outdated Show resolved Hide resolved

shanchao95 force-pushed the new_issue_8373 branch from feeabca to 131edad Compare April 6, 2020 18:30

pshipton approved these changes Apr 6, 2020

View reviewed changes

keithc-ca approved these changes Apr 6, 2020

View reviewed changes

keithc-ca merged commit 34f7695 into ibmruntimes:openj9 Apr 6, 2020

ashu-mehra reviewed Apr 6, 2020

View reviewed changes

pshipton mentioned this pull request Apr 7, 2020

(0.20.0) Add openssl thread synchronization to fix crashes #398

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add openssl thread synchronization to fix crashes #381

Add openssl thread synchronization to fix crashes #381

shanchao95 commented Mar 5, 2020 •

edited by pshipton

Loading

shanchao95 commented Mar 5, 2020

pshipton commented Mar 5, 2020

shanchao95 commented Mar 10, 2020

pshipton commented Mar 10, 2020

shanchao95 commented Mar 12, 2020 •

edited

Loading

pshipton commented Mar 12, 2020

pshipton commented Mar 12, 2020

pshipton commented Mar 13, 2020 •

edited

Loading

pshipton commented Mar 13, 2020 •

edited

Loading

pshipton commented Mar 13, 2020

pshipton commented Mar 17, 2020 •

edited

Loading

alon-sh commented Mar 19, 2020

shanchao95 commented Mar 20, 2020

keithc-ca commented Mar 24, 2020

keithc-ca commented Mar 25, 2020

keithc-ca commented Mar 25, 2020

pshipton commented Mar 25, 2020

keithc-ca commented Mar 30, 2020

keithc-ca commented Mar 30, 2020

keithc-ca commented Apr 6, 2020

keithc-ca commented Apr 6, 2020

pshipton commented Apr 6, 2020

shanchao95 commented Apr 6, 2020

keithc-ca commented Apr 6, 2020

ashu-mehra Apr 6, 2020

keithc-ca Apr 6, 2020

Add openssl thread synchronization to fix crashes #381

Add openssl thread synchronization to fix crashes #381

Conversation

shanchao95 commented Mar 5, 2020 • edited by pshipton Loading

shanchao95 commented Mar 5, 2020

pshipton commented Mar 5, 2020

shanchao95 commented Mar 10, 2020

pshipton commented Mar 10, 2020

shanchao95 commented Mar 12, 2020 • edited Loading

pshipton commented Mar 12, 2020

pshipton commented Mar 12, 2020

pshipton commented Mar 13, 2020 • edited Loading

pshipton commented Mar 13, 2020 • edited Loading

pshipton commented Mar 13, 2020

pshipton commented Mar 17, 2020 • edited Loading

alon-sh commented Mar 19, 2020

shanchao95 commented Mar 20, 2020

keithc-ca commented Mar 24, 2020

keithc-ca commented Mar 25, 2020

keithc-ca commented Mar 25, 2020

pshipton commented Mar 25, 2020

keithc-ca commented Mar 30, 2020

keithc-ca commented Mar 30, 2020

keithc-ca commented Apr 6, 2020

keithc-ca commented Apr 6, 2020

pshipton commented Apr 6, 2020

shanchao95 commented Apr 6, 2020

keithc-ca commented Apr 6, 2020

ashu-mehra Apr 6, 2020

Choose a reason for hiding this comment

keithc-ca Apr 6, 2020

Choose a reason for hiding this comment

shanchao95 commented Mar 5, 2020 •

edited by pshipton

Loading

shanchao95 commented Mar 12, 2020 •

edited

Loading

pshipton commented Mar 13, 2020 •

edited

Loading

pshipton commented Mar 13, 2020 •

edited

Loading

pshipton commented Mar 17, 2020 •

edited

Loading