Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: tree_packing.py #13

Merged
merged 50 commits into from
Sep 5, 2024
Merged

ADD: tree_packing.py #13

merged 50 commits into from
Sep 5, 2024

Conversation

DamienGilliard
Copy link
Collaborator

@DamienGilliard DamienGilliard commented Jul 30, 2024

This very important PR concerns tree packing with respect to the model of the structure. The first method implemented is best illustrated by this illustration:
skeleton_and_model_Carnutes

The main changes are the creation of a packing module. Changes made elsewhere are consequences of the creation of this module, and of the later merge of the main branch to include tests

The changes require a specific test suite

@DamienGilliard
Copy link
Collaborator Author

DamienGilliard commented Aug 4, 2024

blackboard_carnutes_04_08_2024

Skeleton matching as implemented on sunday 04 august

@DamienGilliard DamienGilliard marked this pull request as draft August 15, 2024 07:38
@DamienGilliard DamienGilliard self-assigned this Aug 15, 2024
@DamienGilliard
Copy link
Collaborator Author

DamienGilliard commented Aug 27, 2024

!
Screenshot 2024-08-28 at 02 05 34
image
As of now, the packing updates the database by removing from the database the tree part that is selected . Therefore asking to fit similar elements subsequently returns different trees, because the previously selected tree part is not in the DB anymore.
Basic but crucial

This also means that we need to "reset" the database to its original state whenever we make a mistake or want to try over.

@DamienGilliard DamienGilliard linked an issue Aug 28, 2024 that may be closed by this pull request
@DamienGilliard DamienGilliard marked this pull request as ready for review September 5, 2024 14:58
@DamienGilliard DamienGilliard merged commit 99a913b into main Sep 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add "reset database" button
1 participant