Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically collapse tabs #119

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Automatically collapse tabs #119

merged 4 commits into from
Aug 26, 2024

Conversation

Petingo
Copy link
Collaborator

@Petingo Petingo commented Aug 19, 2024

Description 🤖

Automatically collapse other tabs when a new one is opened.
I also modified the type of m_PaneUIStack to hold just object directly instead of a shared_ptr. I believe it's not necessory to use shared_ptr in this scenrio and it will make the code much more complicated.

(I should have opened a new branch. The commits include some other old stuff)

Type of feature/changes 🌲

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Copy link
Collaborator

@9and3 9and3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@9and3 9and3 merged commit acc5634 into main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI pane's should be set off automatically when collapsing another pane UI
2 participants