Issue617 refactor service #622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice to see you're working on this @dhblum! Thanks a lot for the implementation and requesting review. I'll do so asap, hopefully by the end of this week. |
javiarrobas
reviewed
Apr 3, 2024
|
|
||
| # Job queue configuration | ||
| BOPTEST_JOB_QUEUE_URL=http://goaws:4100/queue/local-queue1 | ||
| AWS_ACCESS_KEY_ID=xxxxxxxxxxxxxxxxxxxx |
There was a problem hiding this comment.
I'd suggest replacing the secrets with environment variables so we can readily use it. Something like:
AWS_ACCESS_KEY_ID=&AWS_ACCESS_KEY_ID
javiarrobas
reviewed
Apr 3, 2024
javiarrobas
reviewed
Apr 3, 2024
javiarrobas
reviewed
Apr 3, 2024
javiarrobas
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Looking good to me @dhblum! just added a couple of small suggestions.
|
Thank you @javiarrobas! I'll take a look at your comments/suggestions, also with @kbenne, who plans to also see if he can replicate the migration but in a way to maintain the Service git history (in this PR I just simply moved files from that repo into this one). |
Co-authored-by: Javier <javier.arroyo@kuleuven.be>
…roject1-boptest into issue617_refactorService
Co-authored-by: Javier <javier.arroyo@kuleuven.be>
…roject1-boptest into issue617_refactorService
|
Closing, continuing in #652. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for #617. So far, it:
api.pydocker-compose.ymland other Dockerfiles to work with the new directly structure.See #617 for remaining todos, especially documentation/readme updates.
@kbenne @javiarrobas Care to provide initial review?