Add Equivalence trait
#45
Conversation
src/map.rs
Outdated
| /// satisfies the equality function passed. | ||
| /// | ||
| /// This function is similar to [`Self::get()`], but provides a shortcut | ||
| /// for lookups where instantiation of keys is expensive. For instance, if |
There was a problem hiding this comment.
Wouldn't this use case be better served by the Equivalent trait? get_by_hash is useful but I think serves a different use case, such as supporting unhashable types or precomputed hashes. For that I wonder if it would be better to expose a lower-level type such as hashbrown's HashTable.
There was a problem hiding this comment.
Great point! I've switched to using an Equivalent trait instead, so we don't need an additional method. This also leaves fewer opportunities for consumers to misuse the API.
src/raw/mod.rs
Outdated
| /// ## Contract | ||
| /// | ||
| /// The implementor must hash like K, if it is hashable. | ||
| pub trait Equivalent<K> |
There was a problem hiding this comment.
I think it's fine to just pull in the equivalent crate for this instead.
|
Just doing a ctrl+f for uses of |
|
Thanks again for the review, both are done! |
|
Perfect, thanks! |
|
Released in 0.1.8. |
This PR adds
get_by_hash()methods that allow for faster lookups when instantiating keys is expensive.I figured I could get away without writing tests, since the implementation of
get()now uses this method internally, so it's implicitly covered :)