Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ArchiveStats a dataclass #275

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Make ArchiveStats a dataclass #275

merged 2 commits into from
Nov 24, 2022

Conversation

btjanaka
Copy link
Member

Description

The stats no longer need to be a namedtuple since we dropped Python 3.6 support. As we add more fields to the namedtuple, it will also get messy if there are users who still unpack it.

TODO

Questions

Status

  • I have read the guidelines in CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka merged commit 0719e62 into master Nov 24, 2022
@btjanaka btjanaka deleted the archive-stats-dataclass branch November 24, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants