Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set plot_centroids to False when plotting #339

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

itsdawei
Copy link
Collaborator

@itsdawei itsdawei commented Jul 14, 2023

Description

cvt_archive_heatmap.Previously, we set plot_centroids to True by default. However, it is easy to mistake the centroids for the solution points. Furthermore, the centroids are usually not immediately useful; for instance, our arm repertoire tutorial turns off the centroids by default.

TODO

  • Change default value
  • Add test for cvt archive heatmap with centroids
  • Update test images
  • Update arm repertoire tutorial

Questions

Status

  • I have read the guidelines in CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in HISTORY.md
  • This PR is ready to go

@itsdawei itsdawei requested a review from btjanaka July 14, 2023 20:03
@itsdawei itsdawei merged commit ab8318f into master Jul 14, 2023
@itsdawei itsdawei deleted the cvt-archive-heatmap-default branch July 14, 2023 20:33
@btjanaka btjanaka mentioned this pull request Jul 15, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants