This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
feat: store initialStates #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
luhc228
commented
Aug 11, 2022
•
luhc228
commented
- 状态管理方案 #395 (comment)
- 更新 README
- 添加部分注释说明
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## release-next #435 +/- ##
================================================
+ Coverage 82.20% 82.23% +0.02%
================================================
Files 87 87
Lines 7448 7448
Branches 941 941
================================================
+ Hits 6123 6125 +2
+ Misses 1319 1317 -2
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ClarkXia
reviewed
Aug 11, 2022
| @@ -16,6 +16,7 @@ | |||
| "@types/react": "^18.0.0", | |||
| "@types/react-dom": "^18.0.0", | |||
| "browserslist": "^4.19.3", | |||
| "regenerator-runtime": "^0.13.9" | |||
| "regenerator-runtime": "^0.13.9", | |||
| "tslib": "^2.4.0" | |||
There was a problem hiding this comment.
所以项目依赖中你会推荐把 tslib 也默认加进去吗
There was a problem hiding this comment.
好多地方都会用到, ts 优先的话我也建议脚手架默认加 tslib 在 devDep
There was a problem hiding this comment.
或者也可以默认先不依赖 tslib，把可能遇到的错误以及解决方式（安装一下 tslib）放在 faq 中
There was a problem hiding this comment.
这里不用增加复杂度了, 直接脚手架里依赖上吧 (开箱即用)
|
可以参考 #519 支持下消费 app data |
wssgcg1213
previously approved these changes
Sep 16, 2022
ClarkXia
previously approved these changes
Sep 22, 2022
wssgcg1213
previously approved these changes
Oct 14, 2022
ClarkXia
approved these changes
Oct 17, 2022
chenjun1011
approved these changes
Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.