This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
feat: support static runtime #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chenjun1011
previously approved these changes
Oct 21, 2022
luhc228
reviewed
Oct 24, 2022
luhc228
approved these changes
Oct 24, 2022
chenjun1011
reviewed
Oct 24, 2022
| await Promise.all(runtimeModules.map(m => runtime.loadModule(m)).filter(Boolean)); | ||
|
|
||
| const { Document } = renderOptions; | ||
| const appContext = runtime.getAppContext(); |
There was a problem hiding this comment.
renderDocument 里的 APPContext 要统一下吗？
There was a problem hiding this comment.
应该不需要，之前看了下 Document 渲染应该不依赖运行时能力，理论上 document 的渲染逻辑要再精简下
chenjun1011
approved these changes
Oct 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
statc runtime说明：对于一些支持在 src/app 入口就可以使用的 API，如 request 的运行时能力，需要在应用数据 / 路由数据加载获取前就需要加载，否则在 getAppData 中将无法享受到统一的配置能力
Close #604 #605