fix: 🐛 bind history to window (#428)

* fix: 🐛 bind history to window ✅ Closes: #426
ice-lab · Oct 20, 2021 · 78f7507 · 78f7507
1 parent df759e1
commit 78f7507
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/packages/icestark-app/CHANGELOG.md b/packages/icestark-app/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.4.2
+
+- [fix] Bind history to window when using `AppLink`. ([#428](https://github.com/ice-lab/icestark/pull/428))
+
 ## 1.4.1
 
 - [feat] correct types of `setLibraryName`. ([#287](https://github.com/ice-lab/icestark/issues/287))

diff --git a/packages/icestark-app/package.json b/packages/icestark-app/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ice/stark-app",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "description": "icestark-app is a JavaScript library for icestark, used by sub-application.",
   "scripts": {
     "build": "rm -rf lib && tsc",

diff --git a/packages/icestark-app/src/AppLink.tsx b/packages/icestark-app/src/AppLink.tsx
@@ -23,7 +23,10 @@ const AppLink = (props: AppLinkProps) => {
           return false;
         }
 
-        const changeState = window.history[replace ? 'replaceState' : 'pushState'];
+        /*
+        * Bind `replaceState` and `pushState` to window to avoid illegal invocation error
+         */
+        const changeState = window.history[replace ? 'replaceState' : 'pushState'].bind(window);
 
         changeState({}, null, linkTo);
       }}

diff --git a/src/AppLink.tsx b/src/AppLink.tsx
@@ -15,13 +15,16 @@ const AppLink: React.SFC<AppLinkProps> = (props: AppLinkProps) => {
     <a
       {...rest}
       href={linkTo}
-      onClick={e => {
+      onClick={(e) => {
         e.preventDefault();
         if (message && window.confirm(message) === false) {
           return false;
         }
 
-        const changeState = window.history[replace ? 'replaceState' : 'pushState'];
+        /*
+        * Bind `replaceState` and `pushState` to window to avoid illegal invocation error
+         */
+        const changeState = window.history[replace ? 'replaceState' : 'pushState'].bind(window);
 
         changeState({}, null, linkTo);
       }}