Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppRouter/AppRoute 兼容 react-router 基本能力 #25

Closed
daysai opened this issue Nov 5, 2019 · 1 comment
Closed

AppRouter/AppRoute 兼容 react-router 基本能力 #25

daysai opened this issue Nov 5, 2019 · 1 comment
Labels
feature request

Comments

@daysai
Copy link
Contributor

daysai commented Nov 5, 2019

背景

  • icestark 将子应用作为 AppRouter/AppRoute 承接，其中 AppRouter 和 react-router 互相兼容，但官方建议框架应用保持足够轻量，希望独立部分作为不同子应用来承接；这类设计对用户造成一定理解成本和使用成本，结合后续 icestark 会推出官方 iframe 的子应用组件。计划在 AppRoute 层增加 render/component 的 props，能直接渲染 react 的基础组件，基本包含 react-router 的能力。

方案

icestark AppRoute 增加 render/component ，支持直接渲染 react 基础组件，涵盖 react-router 基本功能
@daysai daysai mentioned this issue Nov 6, 2019
Merged
5 tasks
@daysai
Copy link
Contributor Author

daysai commented Nov 8, 2019 •
edited
Loading

开发完成，详见 #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imsobear @daysai