Release/1.1.0 #27
Release/1.1.0 #27
Conversation
chore: migrate testing-library
| @@ -60,8 +60,6 @@ function getAppConfig(appRouteProps: AppRouteProps): AppConfig { | |||
| 'useShadow', | |||
| 'ErrorComponent', | |||
| 'LoadingComponent', | |||
| 'NotFoundComponent', | |||
| 'useShadow', | |||
There was a problem hiding this comment.
useShadow 重复了，NotFoundComponent 的渲染逻辑放到 AppRouter 层了，原来都交由 AppRoute 自行处理，所以需要透传 NotFoundComponent 属性。 改之后渲染层级上更合理，后续 LoadingComponent、NotFoundComponent 逐步迁移过去（这块迁移成本稍微高一点，预计1.2.0版本完成）
src/AppRoute.tsx
Outdated
| useShadow?: boolean; | ||
| ErrorComponent?: any; | ||
| LoadingComponent?: any; | ||
| NotFoundComponent?: any; | ||
| component?: React.ReactElement; | ||
| render?: () => React.ReactElement; |
There was a problem hiding this comment.
为什么需要同时支持 component 和 render？
保持跟 react-router 统一，component 意义在于能自给自足的组件，render 支持透传自定义属性，比如 iframe 的 src 等。
src/handleAssets.ts
Outdated
| @@ -39,7 +39,7 @@ function loadAsset( | |||
| element.addEventListener( | |||
| 'error', | |||
| () => { | |||
| callback(isCss ? undefined : new Error(`JS asset loaded error: ${url}`)); | |||
| callback(isCss ? undefined : `JS asset loaded error: ${url}`); | |||
There was a problem hiding this comment.
JS asset -> js assets
JS asset -> js asset 因为报错是针对某一条 js
src/AppRouter.tsx
Outdated
| const { path, basename } = element.props as AppRouteProps; | ||
| const { path, basename, render, component } = element.props as AppRouteProps; | ||
|
|
||
| const commonProps = { location: { pathname, query, hash }, match, history: appHistory }; |
There was a problem hiding this comment.
明确下 render 里需要哪些参数？
目前保持跟 react-router 常用属性一致，location、match、history 等常用属性/方法
There was a problem hiding this comment.
评估是否需要透出 appHistory，个人建议先不要透出。
There was a problem hiding this comment.
评估是否需要透出 appHistory，个人建议先不要透出。
从以往 react-router 的开发经验上，location、match、history 是必备条件。component 和 render 功能的开发，主旨也是支持框架应用替代 react-router 的基本功能，因此这三个优先选择透出。
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@ice/stark", | |||
| "version": "1.0.0", | |||
| "version": "1.0.1", | |||
src/AppRoute.tsx
Outdated
| useShadow?: boolean; | ||
| ErrorComponent?: any; | ||
| LoadingComponent?: any; | ||
| NotFoundComponent?: any; | ||
| component?: React.ReactElement; | ||
| render?: (props?: object) => React.ReactElement; |
There was a problem hiding this comment.
这个不应该是 object，把 commonProps 的类型声明提上来
There was a problem hiding this comment.
这个不应该是 object，把 commonProps 的类型声明提上来
done
src/AppRouter.tsx
Outdated
| @@ -51,13 +52,25 @@ function getHashPath(hash: string = '/'): string { | |||
| return searchIndex === -1 ? hashPath : hashPath.substr(0, searchIndex); | |||
| } | |||
|
|
|||
| /** | |||
| * Render Component | |||
There was a problem hiding this comment.
这种注释无意义，要么就 Render Component, support component={Home} and component={<Home />}
There was a problem hiding this comment.
这种注释无意义，要么就
Render Component, support component={Home} and component={<Home />}
改为 Render Component, compatible with Component and 从函数功能上进行注释
|
ci 这个 warning 是什么？
|
这就是 ErrorComponent、LoadingComponent 的渲染在 AppRoute 层，也是通过 ReactDOM.render() 方式渲染的。注销也是通过 unmountComponentAtNode 方式注销的。所以会有这些 warning。第一个可以通过删掉 cleanup-after-each 解决 |
* fix: rm localUrl api * fix: rm localUrl * chore: migrate testing-library ref testing-library/dom-testing-library#260 * feat: add AppRoute render/component props * chore: rm setupFilesAfterEnv * fix: adjust for cr * fix: adjust JS asset to js asset * fix: rm useless cleanup-after-each * feat: add AppRouteComponentProps ts * chore: update version * fix: interface match to Match
变更点
计划发布时间