Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create @testing-library scope for publishing. #260

Closed
kentcdodds opened this issue May 20, 2019 · 48 comments
Closed

Create @testing-library scope for publishing. #260

kentcdodds opened this issue May 20, 2019 · 48 comments

Comments

@kentcdodds
Copy link
Member

As brought up by @brentvatne: https://twitter.com/notbrent/status/1130517657546043394 and suggested by @vincentriemer

Basically:

- yarn add react-testing-library
+ yarn add @testing-library/react

I think that I would still refer to it in writing/speaking as "react testing library."

I think it's a good idea and I grabbed https://npm.im/~testing-library so we should be good to start doing this.

I just want to hear what folks have to say.

Here's how I think we should do it:

  1. Each package maintainer gets to choose whether they want to be publishing their package under the scope and what version to publish at first.
  2. I think I'd like to publish the ones I'm primarily responsible for as 1.0.0 on that scope.
  3. Publish a new major version of each package that has moved which is immediately deprecated with a message indicating people should migrate to the new scoped package.

What thoughts do you all have?
@timdeschryver
Copy link
Member

Sounds good to me!

@bcarroll22
Copy link

I love it 👍

@timdeschryver timdeschryver mentioned this issue May 20, 2019
Closed
@alexkrolick
Copy link
Collaborator

Sounds good to me

@bcarroll22
Copy link

I think I'd like to publish the ones I'm primarily responsible for as 1.0.0 on that scope.

I'm curious, for my own decision process, what makes you want to do it this way?

@gnapse
Copy link
Member

gnapse commented May 20, 2019

Sounds great! Would like to have your comments on how it went with your packages, and how to proceed with re-publishing ours. I'm not too familiar with making this change.

@kentcdodds
Copy link
Member Author

I'm planning on doing this today and I will probably livestream it.

@kentcdodds
Copy link
Member Author

Here it is: https://www.youtube.com/watch?v=BN5ELGSV25Q

@kentcdodds
Copy link
Member Author

Do we want to rename the repos?

For example: https://github.com/testing-library/dom-testing-library -> https://github.com/testing-library/dom

@bcarroll22
Copy link

👍 I'm good either way

kentcdodds pushed a commit that referenced this issue May 30, 2019
feat: initial release of the scoped package
7639e74 
Reference #260
@kentcdodds
Copy link
Member Author

Let's leave it as-is for now and change it later if we decide it makes more sense later :)

@kentcdodds
Copy link
Member Author

After further investigation I've decided it'd be better to continue with the current versioning scheme because the GitHub releases page (and git tags).

kentcdodds pushed a commit that referenced this issue May 30, 2019
fix(release): manually release a major version
a646246 
There was an issue with a major release, so this manual-releases.md
change is to release a new major version.

Reference: #260

BREAKING CHANGE: You must switch from `dom-testing-library` to `@testing-library/dom`
kentcdodds pushed a commit to testing-library/react-testing-library that referenced this issue May 30, 2019
feat: initial release of scoped package
23da68c 
Reference: testing-library/dom-testing-library#260

BREAKING CHANGE: You must update all imports from 'react-testing-library' to '@testing-library/react'
@kentcdodds
Copy link
Member Author

Ok, dom-testing-library and react-testing-library are done. Going to do cypress-testing-library and then I'll be done with this.

Who else is planning on moving their packages?

cc @testing-library/angular @testing-library/vue @testing-library/user-event @testing-library/core-maintainers @testing-library/jest-dom @testing-library/puppeteer @testing-library/react-native @testing-library/testcafe

@bcarroll22
Copy link

🙋‍♂ gonna do it real soon with NTL and jest-native

kentcdodds pushed a commit to testing-library/cypress-testing-library that referenced this issue May 30, 2019
feat: initial release of scoped package
d354d88 
Reference: testing-library/dom-testing-library#260

BREAKING CHANGE: You need to change your imports from cypress-testing-library to @testing-library/cypress
@bcarroll22
Copy link

Ah, actually will we all need permission to publish to the npm organization?

@kentcdodds
Copy link
Member Author

Yes, you do. Please give me your npm usernames.

@bcarroll22
Copy link

Mine is bcarroll22

@kentcdodds
Copy link
Member Author

You're on there already :)

@kentcdodds
Copy link
Member Author

Make sure you use --access public when running npm publish

@kentcdodds
Copy link
Member Author

I'm pretty much done with all my stuff. If folks could just give me their npm username then I will get you on the npm org and you should be able to publish. If you'd like a hand, please watch the livestream to see what I did :)

@kentcdodds
Copy link
Member Author

Oh, and now we have a bunch of stuff in the docs to update 😬

@timdeschryver
Copy link
Member

I will move the angular-testing-library soon, my npm username is timdeschryver

kaykayehnn added a commit to kaykayehnn/typescript-react-redux-boilerplate that referenced this issue May 30, 2019
@kaykayehnn
Move react-testing-library dependency. Update README
cb2d19f 
react-testing-library has been deprecated in favour of
@testing-library/react
Relevant issue: testing-library/dom-testing-library#260
kaykayehnn added a commit to kaykayehnn/trrb-cli that referenced this issue May 30, 2019
@kaykayehnn
Change react-testing-library to @testing-library/react
25d4110 
Relevant issue: testing-library/dom-testing-library#260
@kentcdodds
Copy link
Member Author

I just sent invites to a bunch of the maintainers of various testing-library packages. If I missed anyone let me know!

ThewBear added a commit to ThewApp/biggame75 that referenced this issue May 31, 2019
@ThewBear
Migrate to @testing-library/react
a5be466 
- testing-library/dom-testing-library#260
kaykayehnn added a commit to kaykayehnn/trrb-cli that referenced this issue Jun 24, 2019
@kaykayehnn
Change react-testing-library to @testing-library/react
6b78613 
Relevant issue: testing-library/dom-testing-library#260
kaykayehnn added a commit to kaykayehnn/typescript-react-redux-boilerplate that referenced this issue Jun 24, 2019
@kaykayehnn
Move react-testing-library dependency. Update README
c4d503c 
react-testing-library has been deprecated in favour of
@testing-library/react
Relevant issue: testing-library/dom-testing-library#260
kentcdodds pushed a commit to testing-library/jest-dom that referenced this issue Jul 8, 2019
feat: initial release of scoped package
f810c8a 
Reference: testing-library/dom-testing-library#260

BREAKING CHANGE: You need to uninstall `jest-dom` and install `@testing-library/jest-dom` instead. Then change your imports from `jest-dom` to `@testing-library/jest-dom`.
@AlexYelkin AlexYelkin mentioned this issue Jul 8, 2019
Merged
@razh razh mentioned this issue Jul 11, 2019
Merged
@miqdadamirali miqdadamirali mentioned this issue Jul 12, 2019
Closed
@MohammedFaragallah MohammedFaragallah mentioned this issue Jul 20, 2019
Closed
@jdelucaa jdelucaa mentioned this issue Jul 26, 2019
Merged
armenzg pushed a commit to mozilla/treeherder that referenced this issue Aug 6, 2019
Switch from jest-dom to @testing-library/jest-dom
f844f51 
`jest-dom` has moved to `@testing-library/jest-dom`. Please uninstall jest-dom and install `@testing-library/jest-dom` instead,
or use an older version of `jest-dom`. If you do upgrade to `@testing-library/jest-dom`, make sure to update your usage of `jest-dom`
to use `@testing-library/jest-dom/extend-expect` rather than simply `jest-dom/extend-expect`. Learn more about this change here:
testing-library/dom-testing-library#260 Thanks!
@armenzg armenzg mentioned this issue Aug 6, 2019
Merged
armenzg pushed a commit to mozilla/treeherder that referenced this issue Aug 8, 2019
Switch from jest-dom to @testing-library/jest-dom
c155dd6 
`jest-dom` has moved to `@testing-library/jest-dom`. Please uninstall jest-dom and install `@testing-library/jest-dom` instead,
or use an older version of `jest-dom`. If you do upgrade to `@testing-library/jest-dom`, make sure to update your usage of `jest-dom`
to use `@testing-library/jest-dom/extend-expect` rather than simply `jest-dom/extend-expect`. Learn more about this change here:
testing-library/dom-testing-library#260 Thanks!
armenzg pushed a commit to mozilla/treeherder that referenced this issue Aug 8, 2019
@armenzg
Switch from jest-dom to @testing-library/jest-dom
8799187 
`jest-dom` has moved to `@testing-library/jest-dom`. Please uninstall jest-dom and install `@testing-library/jest-dom` instead,
or use an older version of `jest-dom`. If you do upgrade to `@testing-library/jest-dom`, make sure to update your usage of `jest-dom`
to use `@testing-library/jest-dom/extend-expect` rather than simply `jest-dom/extend-expect`. Learn more about this change here:
testing-library/dom-testing-library#260 Thanks!
NerdCowboy added a commit to gatsbyjs/gatsby that referenced this issue Aug 14, 2019
@NerdCowboy
Update jest.setup requires
fae00c6 
- jest-dom moved 
testing-library/dom-testing-library#260
- cleanup-after-each is no longer required 
https://github.com/testing-library/react-testing-library/blob/master/cleanup-after-each.js
@NerdCowboy NerdCowboy mentioned this issue Aug 14, 2019
Merged
gatsbybot pushed a commit to gatsbyjs/gatsby that referenced this issue Aug 14, 2019
@NerdCowboy
chore(using-jest): Update jest.setup (#16615)
2c83b40 
* Update jest.setup requires

- jest-dom moved 
testing-library/dom-testing-library#260
- cleanup-after-each is no longer required 
https://github.com/testing-library/react-testing-library/blob/master/cleanup-after-each.js

* update dependencies
gatsbybot pushed a commit to gatsbyjs/gatsby-starter-theme-workspace that referenced this issue Aug 14, 2019
chore(using-jest): Update jest.setup (#16615)
0802e0b 
* Update jest.setup requires

- jest-dom moved
testing-library/dom-testing-library#260
- cleanup-after-each is no longer required
https://github.com/testing-library/react-testing-library/blob/master/cleanup-after-each.js

* update dependencies
daido1976 added a commit to daido1976/react-fs-helsinki-2019 that referenced this issue Aug 18, 2019
@daido1976
$ yarn remove jest-dom && yarn add -D @testing-library/jest-dom
c246465 
Because get following message when run test:

jest-dom has moved to @testing-library/jest-dom. Please uninstall jest-dom and install @testing-library/jest-dom instead, or use an older version of jest-dom.
If you do upgrade to @testing-library/jest-dom, make sure to update your usage of jest-dom to use @testing-library/jest-dom/extend-expect rather than simply jest-dom/extend-expect.
Learn more about this change here: testing-library/dom-testing-library#260
sleepycat added a commit to cds-snc/report-a-cybercrime that referenced this issue Aug 29, 2019
@sleepycat
Replace jest-dom
b4662fc 
This package has been replaced with @testing-library/jest-dom as per
testing-library/dom-testing-library#260
@sleepycat sleepycat mentioned this issue Aug 29, 2019
Merged
danprime pushed a commit to cds-snc/report-a-cybercrime that referenced this issue Aug 30, 2019
@sleepycat
Replace jest-dom (#671)
46c5984 
This package has been replaced with @testing-library/jest-dom as per
testing-library/dom-testing-library#260
@kentcdodds kentcdodds mentioned this issue Sep 2, 2019
Closed
@skube skube mentioned this issue Sep 8, 2019
Open
@bitttttten bitttttten mentioned this issue Oct 1, 2019
Merged
@zhuangya zhuangya mentioned this issue Nov 5, 2019
Merged
imsobear pushed a commit to ice-lab/icestark that referenced this issue Nov 13, 2019
@daysai @imsobear
release: icestark@1.1.0 (#27)
619b175 
* fix: rm localUrl api

* fix: rm localUrl

* chore: migrate testing-library

ref testing-library/dom-testing-library#260

* feat: add AppRoute render/component props

* chore: rm setupFilesAfterEnv

* fix: adjust for cr

* fix: adjust JS asset to js asset

* fix: rm useless cleanup-after-each

* feat: add AppRouteComponentProps ts

* chore: update version

* fix: interface match to Match
mauris added a commit to mauris/react-lh that referenced this issue Dec 10, 2019
@mauris
update jest-dom dependency
7533483 
as described at testing-library/dom-testing-library#260
@nharrisanalyst nharrisanalyst mentioned this issue Jan 30, 2020
Closed
@thdk thdk mentioned this issue Mar 29, 2020
Open
wisdomofgod pushed a commit to ice-lab/icestark that referenced this issue Apr 16, 2020
@daysai @imsobear
release: icestark@1.1.0 (#27)
51084be 
* fix: rm localUrl api

* fix: rm localUrl

* chore: migrate testing-library

ref testing-library/dom-testing-library#260

* feat: add AppRoute render/component props

* chore: rm setupFilesAfterEnv

* fix: adjust for cr

* fix: adjust JS asset to js asset

* fix: rm useless cleanup-after-each

* feat: add AppRouteComponentProps ts

* chore: update version

* fix: interface match to Match
xbucks pushed a commit to xbucks/tauri-crypto-trading that referenced this issue Oct 15, 2023
feat: initial release of scoped package
6711c83 
Reference: testing-library/dom-testing-library#260

BREAKING CHANGE: You must update all imports from 'react-testing-library' to '@testing-library/react'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@gnapse @benmonro @Gpx @kentcdodds @alexkrolick @dfcook @bcarroll22 @timdeschryver @jcousins-ynap