Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@testing-library/react #40

Open
skube opened this issue Sep 8, 2019 · 3 comments
Open

@testing-library/react #40

skube opened this issue Sep 8, 2019 · 3 comments

Comments

@skube
Copy link

skube commented Sep 8, 2019

Shouldn't the examples be updated to point to the new scoped path?

react-testing-library has moved to @testing-library/react. Please uninstall react-testing-library and install @testing-library/react instead, or use an older version of react-testing-library. Learn more about this change here: testing-library/dom-testing-library#260 Thanks! :)

@ovidiuch
Copy link
Owner

ovidiuch commented Sep 8, 2019

They should!

@ojnc
Copy link

ojnc commented Apr 30, 2020

https://react-testing-examples.com/ is wonderful
If not too much effort please update to latest @testing-library/react

I find create-react-app includes jest in innards
so you do not have to install jest as a binary command globally

https://github.com/kentcdodds/react-testing-library-examples
package.json still has "test": "jest", but should be "test": "react-scripts test",

Please make it easy for users like us to use in current context

@ovidiuch
Copy link
Owner

If not too much effort please update to latest @testing-library/react

A contribution would be appreciated, I'm running low on spare time at the moment.

I find create-react-app includes jest in innards...

I'm don't understand this part. This project doesn't use Create React App, and is unrelated to kentcdodds/react-testing-library-examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants