Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the option to shift the cascade vertex to the shower maximum when reading in labels. Instead, the cascade model itself is now responsible for shifting the cascade vertex internally. This is the preferred way to handle this, since an externally applied shift in the labels will cause confusion down the line for the end user. This PR fixes issue #7
The PR also cleans up the models and configs and removes older configs. Some other changes include renaming of
estimate_charge_distribution
tocharge_distribution_type
and now requiringfloat_precision
to be set. This previously was set to the default float32 to maintain backwards compatibility to older models that did not define the precision.Version compatibilities are updated to reflect these breaking changes.