Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shift cascade vertex #25

Merged
merged 4 commits into from
May 31, 2024
Merged

Conversation

mhuen
Copy link
Collaborator

@mhuen mhuen commented May 31, 2024

This PR removes the option to shift the cascade vertex to the shower maximum when reading in labels. Instead, the cascade model itself is now responsible for shifting the cascade vertex internally. This is the preferred way to handle this, since an externally applied shift in the labels will cause confusion down the line for the end user. This PR fixes issue #7

The PR also cleans up the models and configs and removes older configs. Some other changes include renaming of estimate_charge_distribution to charge_distribution_type and now requiring float_precision to be set. This previously was set to the default float32 to maintain backwards compatibility to older models that did not define the precision.

Version compatibilities are updated to reflect these breaking changes.

@mhuen mhuen merged commit de56a7b into CollectBreakingChanges May 31, 2024
0 of 4 checks passed
@mhuen mhuen deleted the MoveShiftCascadeVertex branch May 31, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant