Snow storm labels #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies how SnowStorm values are read in: they are now read in via the SnowstormParametersDict rather than a list of variables that are required to be specified in the correct order. A feature for an arbitrary label key name is also added to the data module, in addition to some smaller tweaks and stabilization for the models.
A larger change to the data input pipeline was also implemented, which now allows to speed up the data pipeline by moving the batch -> event re-formatting of vector tensors to the worker nodes itself. Todo for the future: this can probably be sped up even further, since the loading of the hdf files could directly provide the data in per-event format.