-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix/time window exclusions #8
Conversation
…y for each of the components, which is incorrect and leads to bias
…y for each of the components, which is incorrect and leads to bias
…y for each of the components, which is incorrect and leads to bias
…zation prior to bug fix
…zation prior to bug fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## CollectBreakingChanges #8 +/- ##
=========================================================
Coverage ? 20.58%
=========================================================
Files ? 87
Lines ? 9482
Branches ? 1727
=========================================================
Hits ? 1952
Misses ? 7413
Partials ? 117 ☔ View full report in Codecov by Sentry. |
Note on the failed model prediction test: this test is expected to fail at the moment since an incompatibility check was introduced that triggers when trying to run with models of older software versions. Once all breaking changes are included in the branch |
Previously, when excluding time window exclusions, the individual PDFs of each mixture model component were re-normalized individually. This, however, is incorrect as this will modify the shape of the combined PDF. Instead, the entire mixture PDF has to be re-normalized by the total
dom_cdf_exclusions_sum
.Note: this bugfix is incompatible with models trained in previous versions. To indicate this, the version number is increased.