Fastphotospline

CHANGELOG.txt

@@ -25,6 +25,11 @@ v23.2.1
   event generation from MC, resulting in a great performance increase when
   generating many trials with many events.
 
+- The core.pdf.MultiDimGridPDF class has been adapted to the new Python
+  interface of photospline that supports numpy arrays. The determination of the
+  spline table's basis function indices has been separated from the spline table
+  evaluation which provides an accelerated PDF evaluation.
+
 v23.2.0
 =======
 - Complete overhaul of SkyLLH for more generic handling of parameters
@@ -86,7 +91,7 @@ v23.2.0
 
     - core.event_selection.SpatialBoxEventSelectionMethod:
 
-        Improved calculation of right-ascention difference. Thus, speed-up in
+        Improved calculation of right-ascension difference. Thus, speed-up in
         trial generation when using this event selection method.
 
 - core.scrambling.DataScrambler.scramble_data method also takes Dataset instance
@@ -100,7 +105,7 @@ v23.1.1
 =======
 - bugfix of core.pdf.MultiDimGridPDFSet
 - bugfix of core.pdf.MappedMultiDimGridPDFSet
-- removal of depricated proptery core.pdf.PDFSet.pdf_axes
+- removal of deprecated property core.pdf.PDFSet.pdf_axes
 
 v23.1.0
 =======

skyllh/core/analysis.py

@@ -1882,7 +1882,7 @@ def calculate_fluxmodel_scaling_factors(
         -------
         factors : instance of numpy ndarray
             The (N_sources,)-shaped numpy ndarray of float holding the factors
-            the fluxmodels of the sources need to be scaled in order to obtain
+            the flux models of the sources need to be scaled in order to obtain
             the given mean number of signal events in the detector.
         """
         src_params_recarray =\

skyllh/core/background_generation.py

@@ -174,7 +174,7 @@ def __init__(
             The MC data field names that should be kept in order to be able to
             calculate the background events rates by the functions
             ``get_event_prob_func`` and ``get_mean_func``. All other MC fields
-            will get droped due to computational efficiency reasons.
+            will get dropped due to computational efficiency reasons.
         pre_event_selection_method : instance of EventSelectionMethod | None
             If set to an instance of EventSelectionMethod, this method will
             pre-select the MC events that will be used for later background
@@ -290,7 +290,7 @@ def keep_mc_data_field_names(self):
         """The MC data field names that should be kept in order to be able to
         calculate the background events rates by the functions
         ``get_event_prob_func`` and ``get_mean_func``. All other MC fields
-        will get droped due to computational efficiency reasons.
+        will get dropped due to computational efficiency reasons.
         """
         return self._keep_mc_data_field_names
 
@@ -479,8 +479,8 @@ def generate_events(
         else:
             mean = float_cast(
                 mean,
-                'The mean number of background events must be castable to type '
-                'float!')
+                'The mean number of background events must be cast-able to '
+                'type float!')
 
         # Draw the number of background events from a poisson distribution with
         # the given mean number of background events. This will be the number of
@@ -501,7 +501,7 @@ def generate_events(
         n_bkg_selected = int(np.around(n_bkg * mean_pre_selected / mean, 0))
 
         # Draw the actual background events from the selected events of the
-        # monto-carlo data set.
+        # monte-carlo data set.
         with TaskTimer(tl, 'Draw MC background indices.'):
             bkg_event_indices = self._cache_random_choice(
                 rss=rss,

skyllh/core/binning.py

@@ -98,7 +98,7 @@ def get_bin_indices_from_lower_and_upper_binedges(le, ue, values):
 
 class BinningDefinition(object):
     """The BinningDefinition class provides a structure to hold histogram
-    binning definitions for an analyis.
+    binning definitions for an analysis.
     """
     def __init__(
             self,

skyllh/core/catalog.py

@@ -30,7 +30,7 @@ def __init__(
         name : str
             The name of the catalog.
         sources : sequence of source_type | None
-            The sequence of sources this catalog should be initalized with.
+            The sequence of sources this catalog should be initialized with.
         source_type : type | None
             The type of the source class. If set to None (default), the
             default type defined by SourceCollection will be used.
@@ -52,7 +52,7 @@ def name(self):
     def name(self, name):
         name = str_cast(
             name,
-            'The name property must be castable to type str!')
+            'The name property must be cast-able to type str!')
         self._name = name
 
     def __str__(self):

skyllh/core/config.py

@@ -56,7 +56,7 @@
     },
     'units': {
         # Definition of the internal units to use. These must match with the
-        # units of the monto-carlo data files.
+        # units of the monte-carlo data files.
         'internal': {
             'angle': units.radian,
             'energy': units.GeV,
@@ -120,7 +120,7 @@ def from_yaml(
         Parameters
         ----------
         pathfilename: str | None
-            Path and filename to the yaml file containg the to-be-updated
+            Path and filename to the yaml file containing the to-be-updated
             configuration items.
             If set to ``None``, nothing is done.
 
@@ -156,7 +156,7 @@ def from_dict(
         Parameters
         ----------
         user_dict: dict
-            The dictionary containg the to-be-updated configuration items.
+            The dictionary containing the to-be-updated configuration items.
 
         Returns
         -------
@@ -207,13 +207,13 @@ def enable_tracing(
     def get_wd(
             self,
     ):
-        """Retrieves the absolut path to the working directoy as configured in
+        """Retrieves the absolute path to the working directory as configured in
         this configuration.
 
         Returns
         -------
         wd : str
-            The absolut path to the project's working directory.
+            The absolute path to the project's working directory.
         """
         wd = os.path.abspath(self['project']['working_directory'])
 
@@ -342,7 +342,7 @@ def set_wd(
         Returns
         -------
         wd : str
-            The absolut path to the project's working directory.
+            The absolute path to the project's working directory.
         """
         if path is None:
             path = self['project']['working_directory']

skyllh/core/datafields.py

@@ -90,7 +90,7 @@ def get_joint_names(
         Parameters
         ----------
         datafields : dict
-            The dictionary of datafield names as keys and stages as values.
+            The dictionary of data field names as keys and stages as values.
         stages : int | sequence of int
             The stage(s) for which data field names should get returned.