-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with lvk #41
Open
G-Sommani
wants to merge
47
commits into
main
Choose a base branch
from
compatibility_with_lvk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
8e5c765
<bot> update dependencies*.log files(s)
wipacdevbot 8e90b9c
header identical to lvk
G-Sommani fe4010c
flake8
G-Sommani 0f30bf2
get_paths() instead of collections
G-Sommani 67b8711
try to fix incompatibily with new matplotlib
G-Sommani 29d8d5f
modified julian date as in lvk
G-Sommani beb0558
utc date in isot format
G-Sommani 4d5fd95
add comma
G-Sommani 72a078a
flattened probability map with same units as multiorder map
G-Sommani a725e43
fix type of output for prepare_flattened_map()
G-Sommani bfdcc95
fix type of output for prepare_multiorder_map()
G-Sommani 9aa9adf
remove option dozoom
G-Sommani 2c41db1
<bot> update dependencies*.log files(s)
wipacdevbot 837f3e1
flake8
G-Sommani 4662961
test if nans create problems
G-Sommani 1e2a469
<bot> update dependencies*.log files(s)
wipacdevbot 815a078
debug create_plot
G-Sommani 417c162
debug create_plot
G-Sommani 2237f79
try fix
G-Sommani 5f9359d
try fix
G-Sommani 5561d4e
try fix
G-Sommani e03682b
try fix
G-Sommani 7ef5ede
debug create_plot
G-Sommani 666004b
debug create_plot
G-Sommani 772ff4e
try fix
G-Sommani d071544
try fix
G-Sommani 057aa04
try fix
G-Sommani d1df942
try fix
G-Sommani 9067e4a
try debugging
G-Sommani 36bdd5c
<bot> update dependencies*.log files(s)
wipacdevbot cc90b0f
debug create_plot
G-Sommani 0b3406f
debug create_plot
G-Sommani efc07f2
try fix
G-Sommani 8c9ba4f
debug create_plot
G-Sommani 6ba75c2
try fix
G-Sommani 1bfc2e6
debug create_plot
G-Sommani e709862
try increasing dpi for create_plot
G-Sommani 8c524bd
remove debugging lines and past fixing attempts
G-Sommani 9bfc99b
return to probability per pixel for flattened maps
G-Sommani 5689c30
correct output types
G-Sommani 33ea36f
debug saving of flattened llh maps
G-Sommani 0ea426a
<bot> update dependencies*.log files(s)
wipacdevbot 2fefae9
try specifying the need to save float32
G-Sommani baf4c11
try removing float32 specification
G-Sommani a4ac440
undo all changes
G-Sommani 7d1a726
flattened map as in lvk
G-Sommani 9e492bd
typo
G-Sommani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor comment: LVK just uses
PROB
as the column name for their flattened maps. also probably worth including units for flattened as well, they usepix-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!