Skip to content

Commit

Permalink
Merge pull request #1698 from iced-rs/hide-window-until-ready
Browse files Browse the repository at this point in the history
Hide window until `Renderer` has been initialized
  • Loading branch information
hecrj authored Feb 14, 2023
2 parents efbf66b + 9506fb1 commit 4e93ae8
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 7 deletions.
20 changes: 15 additions & 5 deletions winit/src/application.rs
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,15 @@ where
#[cfg(target_arch = "wasm32")]
let target = settings.window.platform_specific.target.clone();

let builder = settings.window.into_builder(
&application.title(),
event_loop.primary_monitor(),
settings.id,
);
let should_be_visible = settings.window.visible;
let builder = settings
.window
.into_builder(
&application.title(),
event_loop.primary_monitor(),
settings.id,
)
.with_visible(false);

log::info!("Window builder: {:#?}", builder);

Expand Down Expand Up @@ -202,6 +206,7 @@ where
control_sender,
init_command,
window,
should_be_visible,
settings.exit_on_close_request,
);

Expand Down Expand Up @@ -268,6 +273,7 @@ async fn run_instance<A, E, C>(
mut control_sender: mpsc::UnboundedSender<winit::event_loop::ControlFlow>,
init_command: Command<A::Message>,
window: winit::window::Window,
should_be_visible: bool,
exit_on_close_request: bool,
) where
A: Application + 'static,
Expand Down Expand Up @@ -295,6 +301,10 @@ async fn run_instance<A, E, C>(
physical_size.height,
);

if should_be_visible {
window.set_visible(true);
}

run_command(
&application,
&mut cache,
Expand Down
3 changes: 1 addition & 2 deletions winit/src/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@ impl Window {
.with_decorations(self.decorations)
.with_transparent(self.transparent)
.with_window_icon(self.icon)
.with_always_on_top(self.always_on_top)
.with_visible(self.visible);
.with_always_on_top(self.always_on_top);

if let Some(position) = conversion::position(
primary_monitor.as_ref(),
Expand Down

0 comments on commit 4e93ae8

Please sign in to comment.