Skip to content

Commit

Permalink
Use ceil on svg dimensions, fix svg memory usage
Browse files Browse the repository at this point in the history
Calls ceil() on dimension bounds as this appears fix svg memory
unbounded usage because no longer cache miss.

The height and width return from resvg seem to always be ceiling
of float dimensions, so we try to match.
  • Loading branch information
aentity committed Jul 21, 2021
1 parent 27b42ca commit 665422e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions wgpu/src/image/vector.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ impl Cache {
let id = handle.id();

let (width, height) = (
(scale * width).round() as u32,
(scale * height).round() as u32,
(scale * width).ceil() as u32,
(scale * height).ceil() as u32,
);

// TODO: Optimize!
Expand Down Expand Up @@ -122,6 +122,7 @@ impl Cache {
device,
encoder,
)?;
log::debug!("allocating {} {}x{}", id, width, height);

let _ = self.svg_hits.insert(id);
let _ = self.rasterized_hits.insert((id, width, height));
Expand Down

0 comments on commit 665422e

Please sign in to comment.