-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add application feature, which allows to build freestanding wgpu app #1196
Conversation
f1fb67a
to
7c35111
Compare
e6ab610
to
8b0f2e6
Compare
7c35111
to
3cab848
Compare
3cab848
to
076a523
Compare
@hecrj what do you think of this pr, can we be reviewed? |
076a523
to
f45410e
Compare
@hecrj hello i would love see this merged into crates release. perhaps 0.4.3? this is very useful to allow crates release supported to have ios/no application build. i will do whatever is needed to see merged, is there some blocking issue i can help resolve? Thank you I can also rebase onto 0.4 branch if it is easier for you, just tell me what to do :) |
f45410e
to
98b5832
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
I think we can just add the application
feature to iced_winit
for now.
@hecrj I do not see how this can work, here you set feature unconditional: https://github.com/iced-rs/iced/pull/1196/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R99 so user cannot turn off by saying i think my original PR is correct... if you try to build it will fail same as usual:
|
This PR adds new "application" feature, which is default. When user builds with:
it allows to user to build "freestanding" app, with all the nice building blocks of iced, but user responsible for window creation, and rendering.
This also fixes building for iOS, for example, because user can turn off application, and put together pieces they need, similar to integration example.
We can also reduce other dependencies in parts of the workspace I think -- make them optional as example--, to decrease compile time of iced and codegen in this case, but I leave it here for now, for @hecrj to consider. We can do such things in future if desired.
Thank you for your time!
I think this is a better answer than #1190