Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
LineDash
configuration toStroke
and usesRepeatedPattern
fromlyon_algorithms
to closely mimic the HTML Canvas APIs for adding stroked line dash styling.I've updated the Solar System example to use a dashed line pattern for the orbit, which I think showcases this well.
A couple comments / questions:
Stroke
is no longerCopy
, I see no way around thisLineDash
is only considered ifsegments
is not empty. Should we instead use anOption
?segments
, as things may not render properly if negative or non-finite values are used. It is up to the caller to define this properly.Relevant canvas API spec:
https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-setlinedash
Screenshot:
![image](https://user-images.githubusercontent.com/10239377/151417093-8bade212-4c91-468d-b032-bfb85d2dc373.png)