Fix: overlay layout for Responsive
#1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
requested changes
Feb 22, 2022
| @@ -258,7 +258,7 @@ where | |||
| None => self.body.overlay(children.next()?, renderer), | |||
| } | |||
| } else { | |||
| self.body.overlay(layout, renderer) | |||
| self.body.overlay(layout.children().last()?, renderer) | |||
There was a problem hiding this comment.
This seems incorrect, since we are returning the body layout directly in layout when no title bar is present:
iced/native/src/widget/pane_grid/content.rs
Lines 153 to 155 in a536f5e
There was a problem hiding this comment.
Oh you're right 🤔, not sure why this fixes the cases I'm looking at then. There must be an extra layout node coming in somewhere else.
My bad, what I was seeing actually has nothing to do with PaneGrid and was due to the issue with Component's overlay that was already fixed in #1205.
Updated this to remove the PaneGrid changes.
| .unwrap() | ||
| .borrow_overlay() | ||
| .as_ref() | ||
| .map(|overlay| overlay.position()) |
nicksenger
force-pushed
the
fix/overlay-layouts
branch
from
a536f5e
to
a12a92c
Compare
nicksenger
changed the title
PaneGrid & ResponsiveResponsive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout node passed to a child of
Responsivemay be incorrect in some cases. This PR fixes the overlay.