Forward overlay() calls in iced_pure::element::Map #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Map does not override overlay(), calling map() on a pure Element breaks any pick_list inside it (its overlay does not appear). Fix it by implementing overlay() the same way iced_native::element::Map does.
|
I copied the lifetime changes from iced_native because the code didn't compile without them. I didn't look into whether they could be avoided (which would take me a while, I'm a Rust beginner). |
hecrj
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Good catch! I always forget to implement overlay 😅
I copied the lifetime changes from iced_native because the code didn't compile without them. I didn't look into whether they could be avoided (which would take me a while, I'm a Rust beginner).
Thanks for reminding me of this! I have properly loosened the lifetimes of Message and Renderer in d9d6dff.
I believe we can merge this! 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Map does not override overlay(), calling map() on a pure Element
breaks any pick_list inside it (its overlay does not appear).
Fix it by implementing overlay() the same way iced_native::element::Map
does.