Fix nested pure components #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to go ahead and open this up. I've tested it pretty extensively at this point and it seems to be working as intended. |
|
It seems the fix for this is much more straightforward than I previously thought. We simply need to diff the widget tree after rebuilding the cached element in on_event. |
hecrj
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, using a pure component within another pure component will cause the application to panic in certain cases. As far as I can tell, this is because the creation of a component's element is deferred until
diffis called on the corresponding widget tree, which may not happen beforeon_eventif that component is nested within another component which undergoes some internal state change.Repro case here: https://gist.github.com/nicksenger/543e1574b4a5519d9775e94359ae66eb
Diffing the widget tree after processing local events rebuilds the element for any sub-components, which resolves the issue.