-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profile release #1346
Add profile release #1346
Conversation
@hecrj Is there any update on this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this improves the release
profile for the examples at the cost of compilation time, but the default configuration is still valuable during development as we may want to build in release
mode as well.
Instead, I believe we should mention these settings somewhere in our documentation or book
.
Yeah, I understand what you're saying, since Perhaps we can explore the new custom profiles feature in order to reduce binary sizes We could have something like this:
In this way we don't affect the default We can also add the |
That sounds great. If we can just have these settings in a [profile.release-opt]
inherits = "release"
codegen-units = 1
debug = false
lto = true
incremental = false
opt-level = 3
overflow-checks = false
strip = "debuginfo" |
That's great! Thank you! Do you also want me to create a |
Actually, we can just use the new custom profile! I just did that in 7022090. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now! Thank you! 🥳
This PR adds a
profile.release-opt
to reduce binaries size, but at the same time enables some optimizations.Using this profile, I was able to reduce the
bezier_tool
binary from 15.6 MB to 7.1MB, I haven't checked the other binaries though.To use the profile:
I hope this is appreciated, thanks in advance for your review!