Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arc_to #1358

Merged
merged 5 commits into from
Jul 10, 2022
Merged

Fix arc_to #1358

merged 5 commits into from
Jul 10, 2022

Conversation

ThatsNoMoon
Copy link
Contributor

@ThatsNoMoon ThatsNoMoon commented Jun 3, 2022 •
edited by hecrj
Loading

Fixed iced_graphics::widget::canvas::path::Builder::arc_to to behave the same as HTML5's arcTo.

Closes #1357.

@ThatsNoMoon
Copy link
Contributor Author

ThatsNoMoon commented Jun 3, 2022 •
edited
Loading

I also added an example on the arc_to-example branch if you're interested in testing the changes made.

Here's a demo:
arc_to_y3ad1AdQQb

@hecrj hecrj added bug Something isn't working widget canvas labels Jun 4, 2022
@hecrj hecrj added this to the 0.4.3 milestone Jun 4, 2022
ThatsNoMoon and others added 3 commits July 10, 2022 15:12
@ThatsNoMoon @hecrj
fix arc_to
20b58e0 
Fixed `path::Builder::arc_to` to behave the same as [HTML5's `arcTo`]
( https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-arcto ).
@ThatsNoMoon @hecrj
fix another discrepancy with HTML5 arcTo
53d93a3 
HTML5's arcTo does not draw a line from the end of the arc to `b`, so
this should not either.
@hecrj
Add and purify arc example by @ThatsNoMoon
4b8ae71
hecrj
hecrj approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for tackling this 🙇

I have rebased your changes on top of the latest theming (see #1362), and purified and added your cool example to the collection as well in 4b8ae71!

I think we can merge this!

@hecrj hecrj merged commit d1505a9 into iced-rs:master Jul 10, 2022
@hecrj hecrj modified the milestones: 0.4.3, 0.5.0 Sep 20, 2022
@hecrj hecrj mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working canvas widget
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

arc_to does not act like CanvasRenderingContext2D.arcTo
2 participants
@ThatsNoMoon @hecrj