Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update import path in pure canvas example #1373

Merged
merged 2 commits into from
Jul 9, 2022
Merged

Update import path in pure canvas example #1373

merged 2 commits into from
Jul 9, 2022

Conversation

fralonra
Copy link
Contributor

In current version, iced::pure::canvas would be unresolved.
It should be iced::pure::widget::canvas.

hecrj
hecrj approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you! 🙇

@hecrj hecrj added this to the 0.4.3 milestone Jul 1, 2022
@fralonra
Copy link
Contributor Author

fralonra commented Jul 1, 2022

Why it failed on Ubuntu?

fralonra and others added 2 commits July 9, 2022 17:03
@fralonra @hecrj
Update import path in pure canvas example
d4bf49c 
In current version, `iced::pure::canvas` would be unresolved.
It should be `iced::pure::widget::canvas`.
@hecrj
Fix doc example in pure::canvas::Program
fb1e391 
The `widget` module was missing.
@hecrj hecrj merged commit c4c1221 into iced-rs:master Jul 9, 2022
@hecrj hecrj modified the milestones: 0.4.3, 0.5.0 Sep 20, 2022
@hecrj hecrj mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
canvas documentation widget
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fralonra @hecrj