Don't publish redundant on_scroll offsets
#1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
requested changes
Apr 12, 2023
tarkah
force-pushed
the
optimization/scrollable-publish
branch
from
5c2cadc
to
4125c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps improve scrollable performance by suppressing redundant messages from getting published when the
RelativeOffsethasn't changed.I noticed the scrolling is very sluggish on debug mode, even with few elements. When quickly scrolling, dozens of redundant messages were coming across
updatecausing unnecessary state changes / re-renders.This improves the snappiness of scrollables in debug mode a lot.