Invalidate responsive layout when shell layout is invalidated #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarkah
force-pushed
the
fix/responsive-layout
branch
from
c399764
to
ac7b77f
Compare
tarkah
changed the title
hecrj
requested changes
Apr 18, 2023
Co-authored-by: Héctor Ramón <hector0193@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsivelayout was only being recomputed ifsizechanged. This caused a panic if a downstream widget changed betweenlayoutcalls of the sameview/ User Interface root element. This is technically possible withComponentand panic's can be reliably recreated by nesting aComponentinside aResponsiveand returning totally different elements from it'sviewafter processing updates.