Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Total and Used Ram in Example and Add Videos for Examples #2130

Closed
wants to merge 22 commits into from
Closed

fix: Total and Used Ram in Example and Add Videos for Examples #2130

wants to merge 22 commits into from

Conversation

Tahinli
Copy link
Contributor

@Tahinli Tahinli commented Nov 5, 2023

Total and used ram was showing like TB and GB level in system information example, but the actual values are GB and MB.
I added videos about examples that don't have visual showcase.

Total and Used Ram was showing like TB and GB level but the actual values are GB and MB
added short video about arc example
added short video about arc example
added short video about custom quad example
added short video about editor example
added short video about events example
added short video about exit example
added short video about gradient example
added short video about lazy example
added short video about loading spinners example
added short video about modal example
added short video about multitouch example
deleted pokedex gif which is in wrong example
added short video about progress bar example
added short video about screenshot example
added short video about sierpinski-triangle example

previous gif was old but i didn't delete it, I don't know decide which one do you want; mine or old one.
added short video about svg example
added short video about system information example
added short video about toast example
added short video about tooltip example
added short video about visible bounds example
added short video about websocket example
@Tahinli Tahinli changed the title fix: Total and Used Ram fix: Total and Used Ram in Example Nov 8, 2023
@Tahinli Tahinli changed the title fix: Total and Used Ram in Example fix: Total and Used Ram in Example and Add Videos for Examples Nov 8, 2023
@max397574
Copy link

I think we definitely don't want to link to assets in your fork
you should just use github and drag and drop the videos e.g. into an issue or into the readmes to get them uploaded and get a link to them like this

@Tahinli
Copy link
Contributor Author

Tahinli commented Nov 10, 2023

I think we definitely don't want to link to assets in your fork
you should just use github and drag and drop the videos e.g. into an issue or into the readmes to get them uploaded and get a link to them like this

Actually i just dragged and dropped into readme files.
As i understand you are trying to copy video links and add to repositories, instead of doing this why dont you just edit (if needed [ i had given permission to edit this pr already]) then merge into proper repository. So this links will be "our" instead of "mine". Basically i will delete my repo after pr ( i just fork when i need then delete when it's done) so link will be "yours".

But if still something wrong or i miss something, i try to fix, if you show me how to do.

@hecrj hecrj added this to the 0.12 milestone Jan 31, 2024
@hecrj hecrj added bug Something isn't working fix labels Jan 31, 2024
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 🙇

Could we move this work to https://github.com/iced-rs/iced-rs.github.io by creating a PR for each video file and adding it in the static/examples folder? This way, it'd be easier for us to review and iterate on the videos.

I can update the READMEs myself afterwards.

@hecrj
Copy link
Member

hecrj commented Feb 2, 2024

I will merge the first commit here with the work in #2223.

@hecrj hecrj closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants