-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wgpu
to 0.19
, glyphon
to 0.5
, softbuffer
to 0.4
, window-clipboard
to 0.4
, and raw-window-handle
to 0.6
#2191
Conversation
dcc26e7
to
181ecb6
Compare
Wgpu 0.19 has just been released. But this depends on grovesNL/glyphon#80, and an update to |
181ecb6
to
7289b60
Compare
I think this should basically be ready pending glyphon and hecrj/window_clipboard#24. If everything is working properly. |
And update `glyphon` and `window_clipboard`
e654d65
to
b9dc106
Compare
wgpu
to 0.19
, glyphon
to 0.4
, softbuffer
to 0.4
, and raw-window-handle
to 0.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks! 🥳
I have simplified some stuff here and there. Let me know what you think and we can merge.
wgpu
to 0.19
, glyphon
to 0.4
, softbuffer
to 0.4
, and raw-window-handle
to 0.6
wgpu
to 0.19
, glyphon
to 0.5
, softbuffer
to 0.4
, and raw-window-handle
to 0.6
wgpu
to 0.19
, glyphon
to 0.5
, softbuffer
to 0.4
, and raw-window-handle
to 0.6
wgpu
to 0.19
, glyphon
to 0.5
, softbuffer
to 0.4
, window-clipboard
to 0.4
, and raw-window-handle
to 0.6
fda8522
to
bdb8f49
Compare
Those changes seem reasonable. Out-of-order ages won't currently happen with softbuffer, but might in the future if it makes sense for any backend, so that seems reasonable. Using the max age that's been seen seems like a better idea than what I had. It means not having damage tracking for the first couple frames (which perhaps is why I didn't think of it), but that's reasonable. |
@ids1024 Awesome! Currently blocked by gfx-rs/wgpu#5088. |
We could probably detect if the dx12 backend is being used an then set |
This seems a bit hacky, I've spoken with the wgpu team and they intend to release a patch release for this fix. I already have an approved PR waiting to be merged that fixes the issue. |
gfx-rs/wgpu#5088 is fixed by gfx-rs/wgpu#5091! |
Let's merge then! |
Based on #2169 and #2190. This updates wgpu to the latest
trunk
(the last release doesn't useraw-window-handle
0.6).This can't be merged until those two PRs are, and when a wgpu release is made. I just wanted to test Iced with newer Wgpu changes. And to see how the API changes here.
This should make the API here safe, while
RawWindowHandle
/RawDisplayHandle
can be unsafe to use, since they can contain pointers and don't constrain the lifetime.Problems:
Context
andSurface
fromW
, we needW: Clone
. So this adds anArc
aroundwinit::window::Window
.wgpu::WasmNotSendSync
bounds are a bit awkward.Compositor
to handle non-'static
W
. Need to try getting that to work.window_clipboard
will need to be updated for raw-window-handle 0.6If the way softbuffer and wgpu use
WindowHandle
/DisplayHandle
is problematic for iced, perhaps changes could be made there.Closes #2190.