Decouple Key from keyboard::Modifiers and apply them to text in KeyboardInput
#2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wash2
force-pushed
the
modifiers-text
branch
2 times, most recently
from
3dca7f1
to
3d4e3d3
Compare
|
I see. What is the use case for this? It also seems that |
hecrj
force-pushed
the
modifiers-text
branch
from
3d4e3d3
to
4aaa4f2
Compare
hecrj
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
I think this makes sense. I have also decoupled the Key from the keyboard modifiers, since it seems winit doesn't do that by default.
Wasm keeps the old behavior, since the supplement trait isn't implemented there. We'll have to figure out how to keep the API consistent there eventually.
hecrj
changed the title
Key from keyboard::Modifiers and apply them to text in KeyboardInput
Oh sorry, I did not see this until now 😅 . The control characters are important in a terminal application, like cosmic-term, as an example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input like "ctrl + [a-z]" produces text like "a" instead of control characters when not accounting for modifiers. For Character keys, in most cases the text from the winit
KeyEventshould match the received character anyway, so maybe it would be better to pass the text with modifiers accounted for.