Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for download with progress tracking #232

Merged
merged 6 commits into from
Mar 23, 2020
Merged

Add example for download with progress tracking #232

merged 6 commits into from
Mar 23, 2020

Conversation

Songtronix
Copy link
Contributor

No description provided.

@Songtronix Songtronix force-pushed the songtronix/add-download-example branch from 18ac2ed to f97e49f Compare March 23, 2020 14:56
@Songtronix Songtronix mentioned this pull request Mar 23, 2020
Closed
@Songtronix Songtronix force-pushed the songtronix/add-download-example branch from f97e49f to fff333f Compare March 23, 2020 16:54
@Songtronix
Copy link
Contributor Author

If someone has an idea on how to integrate proper error handling into that I am surely interested!

@hecrj
Copy link
Member

hecrj commented Mar 23, 2020

I am working on an improved version.

hecrj added 3 commits March 23, 2020 20:34
@hecrj
Improve download_progress example
30c7db3 
- Use `reqwest` with `Response::chunk` to notify progress.
- Turn example state into an enum
@hecrj
Rename downloader module to download
b92e1f9
@hecrj
Handle errors in download_progress example
0d719bb
@hecrj
Copy link
Member

hecrj commented Mar 23, 2020

I have updated the example to use reqwest, which implements Response::chunk and allows us to track progress more elegantly.

I also changed the example code a bit and renamed some things. Let me know what you think!

Download progress - Iced

@Songtronix
Copy link
Contributor Author

I love it! 💙

@hecrj hecrj changed the title WIP: Add example for download with progress tracking Add example for download with progress tracking Mar 23, 2020
hecrj
hecrj approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I think we can merge this then.

Thank you for putting this together! 🍻

@hecrj hecrj added the improvement An internal improvement label Mar 23, 2020
@hecrj hecrj added this to the 0.1.0 milestone Mar 23, 2020
@hecrj hecrj merged commit 784b8ee into iced-rs:master Mar 23, 2020
@Songtronix Songtronix deleted the songtronix/add-download-example branch March 24, 2020 11:08
@Songtronix Songtronix mentioned this pull request Mar 27, 2020
Merged
@hecrj hecrj mentioned this pull request Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Folyd Folyd Folyd approved these changes

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
improvement An internal improvement
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Songtronix @hecrj @Folyd