Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support wasm target for download_progress #2419

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Support wasm target for download_progress #2419

merged 2 commits into from
Sep 10, 2024

Conversation

skygrango
Copy link
Contributor

@skygrango skygrango commented May 2, 2024 •
edited
Loading

I think it works, but I did make some tricky modifications because

  1. reqwest doesn't support chunk method for wasm, I have to replace chunk by stream
  2. the futures generated by wasm_bindgen NO Send, so I have to pin stream

螢幕截圖_20240502_171755

@skygrango skygrango force-pushed the wasm/support-download_progress branch 2 times, most recently from e4df484 to 5181677 Compare May 3, 2024 03:56
@skygrango skygrango changed the title Support wasm target for download_progress Support wasm target for download_progress May 3, 2024
@hecrj hecrj added this to the 0.13 milestone Sep 10, 2024
@hecrj hecrj added feature New feature or request documentation addition labels Sep 10, 2024
@hecrj hecrj force-pushed the wasm/support-download_progress branch from 9e162a7 to 0053cc0 Compare September 10, 2024 17:25
hecrj
hecrj approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I unified the bytes_stream approach and simplified the example with the new stream::try_channel helper.

@hecrj hecrj merged commit 7683447 into iced-rs:master Sep 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
addition documentation feature New feature or request
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.
2 participants
@skygrango @hecrj