Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slider #2610

Closed
wants to merge 2 commits into from
Closed

Fix slider #2610

wants to merge 2 commits into from

Conversation

wiiznokes
Copy link
Contributor

@wiiznokes wiiznokes commented Sep 26, 2024

attempt to fix pop-os/cosmic-settings#628

currently, the grab handle seems a little off, but i'm not sure this is a layout bug.

master
Capture d’écran du 2024-09-26 23-42-39
pr
Capture d’écran du 2024-09-26 23-43-42

@wiiznokes
Copy link
Contributor Author

wiiznokes commented Sep 26, 2024

Hum, i'm starting to think its a cosmic only issue. Will see when they rebase their fork

@hecrj
Copy link
Member

hecrj commented Oct 2, 2024

I think this reverts #1721.

@hecrj hecrj closed this Oct 2, 2024
@hecrj hecrj added this to the 0.14 milestone Oct 2, 2024
@hecrj hecrj added bug Something isn't working widget fix labels Oct 2, 2024
@wiiznokes
Copy link
Contributor Author

Initially, i wanted to fix a cosmic applet that use the slider from Iced
screenshot-2024-10-02-15-38-05
(only visible on hover)

but yeah, it will require more investigation from me. Sorry for the useless PR

@hecrj
Copy link
Member

hecrj commented Oct 2, 2024

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

At 100% volume, handle appears off center with volume marker
2 participants