Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document that img handle constructors guess fmt #324

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

ethanpailes
Copy link
Contributor

This patch documents the fact that a couple of the image
handle constructors know how to guess the image format based
on the data that they are provided.

I had to dig through iced sources until I discovered that those
routines ultimately boil down to stuff like image::load_from_memory
from the image crate, so I thought I would save others the trouble
of doing the same reverse-engineering

@ethanpailes ethanpailes force-pushed the document-image-format-guessing branch from 452fc8c to 2a73990 Compare April 26, 2020 19:03
This patch documents the fact that a couple of the image
handle constructors know how to guess the image format based
on the data that they are provided.

I had to dig through `iced` sources until I discovered that those
routines ultimately boil down to stuff like [image::load_from_memory][1]
from the `image` crate, so I thought I would save others the trouble
of doing the same reverse-engineering

[1]: https://docs.rs/image/0.23.4/image/fn.load_from_memory.html
@ethanpailes ethanpailes force-pushed the document-image-format-guessing branch from 2a73990 to da2ab42 Compare April 26, 2020 19:03
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

This depends mainly on the renderer implementation. However, we will most likely move image::Handle and svg::Handle to iced_wgpu soon.

Therefore, I believe we can merge this.

@hecrj hecrj merged commit e0aa89c into iced-rs:master Apr 27, 2020
@hecrj hecrj added the improvement An internal improvement label Apr 27, 2020
@hecrj hecrj added this to the 0.2.0 milestone Apr 27, 2020
@ethanpailes ethanpailes mentioned this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An internal improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants